netdev - Re: [PATCH v2 net-next 1/5] net: dsa: microchip: add rmon grouping for ethtool statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Feb 2023 04:40:31 +0000
From:   <Rakesh.Sankaranarayanan@...rochip.com>
To:     <olteanv@...il.com>
CC:     <andrew@...n.ch>, <davem@...emloft.net>, <pabeni@...hat.com>,
        <Thangaraj.S@...rochip.com>, <Woojung.Huh@...rochip.com>,
        <linux-kernel@...r.kernel.org>, <f.fainelli@...il.com>,
        <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <UNGLinuxDriver@...rochip.com>, <kuba@...nel.org>
Subject: Re: [PATCH v2 net-next 1/5] net: dsa: microchip: add rmon grouping
 for ethtool statistics

Hi Vlad,
On Fri, 2023-02-17 at 18:53 +0200, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Fri, Feb 17, 2023 at 04:32:07PM +0530, Rakesh Sankaranarayanan
> wrote:
> >     Add support for ethtool standard device statistics grouping.
> > Support rmon
> >     statistics grouping using rmon groups parameter in ethtool
> > command. rmon
> >     provides packet size based range grouping. Common mib
> > parameters are used
> >     across all KSZ series swtches for packet size statistics,
> > except for
> >     KSZ8830. KSZ series have mib counters for packets with size:
> >     - less than 64 Bytes,
> >     - 65 to 127 Bytes,
> >     - 128 to 255 Bytes,
> >     - 256 to 511 Bytes,
> >     - 512 to 1023 Bytes,
> >     - 1024 to 1522 Bytes,
> >     - 1523 to 2000 Bytes and
> >     - More than 2001 Bytes
> >     KSZ8830 have mib counters upto 1024-1522 range only. Since no
> > other change,
> >     common range used across all KSZ series, but used upto only
> > upto 1024-1522
> >     for KSZ8830.
> 
> Why are all commit messages indented in this way? Please keep the
> default text indentation at 0 characters. I have never seen this
> style
> in "git log".
Sure, will update the indentation in next version
> 
> > 
> > Co-developed-by: Thangaraj Samynathan <Thangaraj.S@...rochip.com>
> 
> Documentation/process/submitting-patches.rst:
> 
> Co-developed-by: states that the patch was co-created by multiple
> developers;
> it is used to give attribution to co-authors (in addition to the
> author
> attributed by the From: tag) when several people work on a single
> patch.  Since
> Co-developed-by: denotes authorship, every Co-developed-by: must be
> immediately
> followed by a Signed-off-by: of the associated co-author.  Standard
> sign-off
> procedure applies, i.e. the ordering of Signed-off-by: tags should
> reflect the
> chronological history of the patch insofar as possible, regardless of
> whether
> the author is attributed via From: or Co-developed-by:.  Notably, the
> last
> Signed-off-by: must always be that of the developer submitting the
> patch.
Will add Signed-off-by information in next revision