netdev - Re: [PATCH v11 bpf-next 10/10] selftests/bpf: tests for using dynptrs to parse skb and xdp buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230222201754.vsqi7s4nhngolok5@MacBook-Pro-6.local>
Date:   Wed, 22 Feb 2023 12:17:54 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Joanne Koong <joannelkoong@...il.com>
Cc:     bpf@...r.kernel.org, martin.lau@...nel.org, andrii@...nel.org,
        ast@...nel.org, memxor@...il.com, daniel@...earbox.net,
        netdev@...r.kernel.org, kernel-team@...com, toke@...nel.org
Subject: Re: [PATCH v11 bpf-next 10/10] selftests/bpf: tests for using
 dynptrs to parse skb and xdp buffers

On Tue, Feb 21, 2023 at 10:07:47PM -0800, Joanne Koong wrote:
>  
> -SEC("tp/syscalls/sys_enter_nanosleep")
> +SEC("tracepoint/syscalls/sys_enter_nanosleep")

Not sure what this was for, but s390 tests are failing:
libbpf: prog 'test_read_write': can't attach BPF program w/o FD (did you load it?)
libbpf: prog 'test_read_write': failed to attach to tracepoint 'syscalls/sys_enter_nanosleep': Invalid argument
verify_success:FAIL:bpf_program__attach unexpected error: -22
Please see:
https://github.com/kernel-patches/bpf/actions/runs/4240181429/jobs/7374285371

> +extern int bpf_dynptr_from_skb(struct __sk_buff *skb, __u64 flags,
> +			       struct bpf_dynptr *ptr__uninit) __ksym;
> +extern void *bpf_dynptr_slice_rdwr(const struct bpf_dynptr *ptr, __u32 offset,
> +			      void *buffer, __u32 buffer__sz) __ksym;

Please move it to some common header like bpf_experimental.h or any other.