netdev - Re: [PATCH net,v3,2/2] selftests: fib_tests: Add test cases for IPv4/IPv6 in route notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef58e253-b035-aae8-0eb7-c3e73dd1f3c6@kernel.org>
Date:   Tue, 21 Feb 2023 20:20:36 -0700
From:   David Ahern <dsahern@...nel.org>
To:     Lu Wei <luwei32@...wei.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net,v3,2/2] selftests: fib_tests: Add test cases for
 IPv4/IPv6 in route notify

On 2/21/23 9:20 PM, Lu Wei wrote:
> @@ -655,6 +655,99 @@ fib_nexthop_test()
>  	cleanup
>  }
>  
> +fib6_notify_test()
> +{
> +	setup
> +
> +	echo
> +	echo "Fib6 info length calculation in route notify test"
> +	set -e
> +
> +	for i in 10 20 30 40 50 60 70;
> +	do
> +		$IP link add dummy_$i type dummy
> +		$IP link set dev dummy_$i up
> +		$IP -6 address add 2001:$i::1/64 dev dummy_$i
> +	done
> +
> +	$IP -6 route add 2001::/64 \
> +                nexthop encap ip6 dst 2002::10 via 2001:10::2 dev dummy_10 \
> +                nexthop encap ip6 dst 2002::20 via 2001:20::2 dev dummy_20 \
> +                nexthop encap ip6 dst 2002::30 via 2001:30::2 dev dummy_30 \
> +                nexthop encap ip6 dst 2002::40 via 2001:40::2 dev dummy_40 \
> +                nexthop encap ip6 dst 2002::50 via 2001:50::2 dev dummy_50 \
> +                nexthop encap ip6 dst 2002::60 via 2001:60::2 dev dummy_60


I think you want the non-lwtunnel path to be first (it is the one
assumed to have the same size as the remaining paths).


> +
> +	set +e
> +
> +	$NS_EXEC ip monitor route &> errors.txt &
> +
> +	sleep 2
> +	$IP -6 route append 2001::/64 via 2001:70::2 dev dummy_70
> +
> +	err=`cat errors.txt |grep "Message too long"`
> +	if [ -z "$err" ];then
> +		ret=0
> +	else
> +		ret=1
> +	fi
> +
> +	log_test $ret 0 "ipv6 route add notify"
> +
> +	{ kill %% && wait %%; } 2>/dev/null
> +
> +	#rm errors.txt
> +
> +	cleanup &> /dev/null
> +}
> +
> +
> +fib_notify_test()
> +{
> +	setup
> +
> +	echo
> +	echo "Fib4 info length calculation in route notify test"
> +
> +	set -e
> +
> +	for i in 10 20 30 40 50 60 70;
> +	do
> +		$IP link add dummy_$i type dummy
> +		$IP link set dev dummy_$i up
> +		$IP address add 20.20.$i.2/24 dev dummy_$i
> +	done
> +
> +	$NS_EXEC ip monitor route &> errors.txt &
> +	sleep 2
> +
> +        $IP route add 10.0.0.0/24 \
> +                nexthop encap ip dst 192.168.10.10 via 20.20.10.1 dev dummy_10 \
> +                nexthop encap ip dst 192.168.10.20 via 20.20.20.1 dev dummy_20 \
> +                nexthop encap ip dst 192.168.10.30 via 20.20.30.1 dev dummy_30 \
> +                nexthop encap ip dst 192.168.10.40 via 20.20.40.1 dev dummy_40 \
> +                nexthop encap ip dst 192.168.10.50 via 20.20.50.1 dev dummy_50 \
> +                nexthop encap ip dst 192.168.10.60 via 20.20.60.1 dev dummy_60 \
> +                nexthop via 20.20.70.1 dev dummy_70

same here.