netdev - Re: [PATCH v2 1/2] wifi: ath11k: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2023 09:51:52 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        junyuu@...omium.org,
        Youghandhar Chintala <quic_youghand@...cinc.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Nick Kossifidis <mickflemm@...il.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Douglas Anderson <dianders@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Manikanta Pubbisetty <quic_mpubbise@...cinc.com>,
        Marc Zyngier <maz@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] wifi: ath11k: Use platform_get_irq() to get the
 interrupt

Douglas Anderson <dianders@...omium.org> wrote:

> As of commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ
> resource from DT core"), we need to use platform_get_irq() instead of
> platform_get_resource() to get our IRQs because
> platform_get_resource() simply won't get them anymore.
> 
> This was already fixed in several other Atheros WiFi drivers,
> apparently in response to Zeal Robot reports. An example of another
> fix is commit 9503a1fc123d ("ath9k: Use platform_get_irq() to get the
> interrupt"). ath11k seems to have been missed in this effort, though.
> 
> Without this change, WiFi wasn't coming up on my Qualcomm sc7280-based
> hardware. Specifically, "platform_get_resource(pdev, IORESOURCE_IRQ,
> i)" was failing even for i=0.
> 
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
> 
> Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
> Fixes: 00402f49d26f ("ath11k: Add support for WCN6750 device")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> Tested-by: Jun Yu <junyuu@...omium.org>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

2 patches applied to ath-next branch of ath.git, thanks.

f117276638b7 wifi: ath11k: Use platform_get_irq() to get the interrupt
95c95251d054 wifi: ath5k: Use platform_get_irq() to get the interrupt

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230201084131.v2.1.I69cf3d56c97098287fe3a70084ee515098390b70@changeid/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches