netdev - Re: [PATCH ethtool] uapi: if.h: fix linux/libc-compat.h include on Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACXRmJiuDeBW4in51_TUG5guLHLc7HZqfCTxCwMr6y_xGdUR5g@mail.gmail.com>
Date:   Thu, 23 Feb 2023 21:38:41 +0100
From:   Thomas Devoogdt <thomas@...oogdt.com>
To:     Thomas Devoogdt <thomas@...oogdt.com>
Cc:     Michal Kubecek <mkubecek@...e.cz>, netdev@...r.kernel.org,
        Thomas Devoogdt <thomas.devoogdt@...co.com>
Subject: Re: [PATCH ethtool] uapi: if.h: fix linux/libc-compat.h include on
 Linux < 3.12

Hi,

I now see that these headers are simply synced with (and even
committed to) the upstream kernel. So having a kernel version check
there is probably not something we want to do. Better would be to
incorporate the "libc-compat.h" header as well to fix compilation on
Linux < 3.12. This is similar to the added "if.h" header itself in
commit https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/uapi/linux/if.h?id=0b09751eb84178d19e4f92543b7fb1e4f162c236,
which added support for Linux < 4.11.

Let me know what you think, and if further action is needed from my

Kr,

Thomas Devoogdt