netdev - Re: [PATCH v4 3/3] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2023 10:40:45 +0000
From:   Neeraj sanjay kale <neeraj.sanjaykale@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "marcel@...tmann.org" <marcel@...tmann.org>,
        "johan.hedberg@...il.com" <johan.hedberg@...il.com>,
        "luiz.dentz@...il.com" <luiz.dentz@...il.com>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>,
        "hdanton@...a.com" <hdanton@...a.com>,
        "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@....com>,
        Rohit Fule <rohit.fule@....com>,
        Sherry Sun <sherry.sun@....com>
Subject: Re: [PATCH v4 3/3] Bluetooth: NXP: Add protocol support for NXP
 Bluetooth chipsets

Hi Greg,

Thank you for reviewing this patch.

> > +             bt_dev_info(hdev, "Set UART break: %s, status=%d",
> > +                         ps_state == PS_STATE_AWAKE ? "off" : "on",
> > + status);
> 
> You have a lot of "noise" in this driver, remove all "info" messages, as if a
> driver is working properly, it is quiet.
> 
Replaced all bt_dev_info() and bt_dev_err() with bt_dev_dbg() for all instances where user action is not possible.

> 
> > +     } else if (req_len == sizeof(uart_config)) {
> > +             uart_config.clkdiv.address = __cpu_to_le32(CLKDIVADDR);
> > +             uart_config.clkdiv.value = __cpu_to_le32(0x00c00000);
> > +             uart_config.uartdiv.address = __cpu_to_le32(UARTDIVADDR);
> > +             uart_config.uartdiv.value = __cpu_to_le32(1);
> > +             uart_config.mcr.address = __cpu_to_le32(UARTMCRADDR);
> > +             uart_config.mcr.value = __cpu_to_le32(MCR);
> > +             uart_config.re_init.address = __cpu_to_le32(UARTREINITADDR);
> > +             uart_config.re_init.value = __cpu_to_le32(INIT);
> > +             uart_config.icr.address = __cpu_to_le32(UARTICRADDR);
> > +             uart_config.icr.value = __cpu_to_le32(ICR);
> > +             uart_config.fcr.address = __cpu_to_le32(UARTFCRADDR);
> > +             uart_config.fcr.value = __cpu_to_le32(FCR);
> > +             uart_config.crc = swab32(nxp_fw_dnld_update_crc(0UL,
> > +                                                             (char *)&uart_config,
> > +                                                             sizeof(uart_config) - 4));
> > +             serdev_device_write_buf(nxpdev->serdev, (u8 *)&uart_config,
> req_len);
> > +             serdev_device_wait_until_sent(nxpdev->serdev, 0);
> 
> You are sending magic commands over the serial connection, are you sure
> that is ok?
Yes, we are sending this only when the BT chip's bootloader is requesting for payload for the CMD5 sent earlier during FW download.

Thanks,
Neeraj