netdev - Re: [PATCH] wifi: rtl8xxxu: fixing transmisison failure for rtl8192eu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c024519-3c5c-dd83-6b71-14b2747084fd@gmail.com>
Date:   Fri, 24 Feb 2023 18:44:19 +0200
From:   Bitterblue Smith <rtl8821cerfe2@...il.com>
To:     Jun ASAKA <JunASAKA@...040330.moe>, Jes.Sorensen@...il.com
Cc:     kvalo@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: rtl8xxxu: fixing transmisison failure for rtl8192eu

On 08/01/2023 14:49, Bitterblue Smith wrote:
> On 08/01/2023 11:29, Jun ASAKA wrote:
>> On 07/01/2023 22:17, Bitterblue Smith wrote:
>>
>>> On 17/12/2022 05:06, Jun ASAKA wrote:
>>>> Fixing transmission failure which results in
>>>> "authentication with ... timed out". This can be
>>>> fixed by disable the REG_TXPAUSE.
>>>>
>>>> Signed-off-by: Jun ASAKA <JunASAKA@...040330.moe>
>>>> ---
>>>>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 5 +++++
>>>>   1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>>>> index a7d76693c02d..9d0ed6760cb6 100644
>>>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>>>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>>>> @@ -1744,6 +1744,11 @@ static void rtl8192e_enable_rf(struct rtl8xxxu_priv *priv)
>>>>       val8 = rtl8xxxu_read8(priv, REG_PAD_CTRL1);
>>>>       val8 &= ~BIT(0);
>>>>       rtl8xxxu_write8(priv, REG_PAD_CTRL1, val8);
>>>> +
>>>> +    /*
>>>> +     * Fix transmission failure of rtl8192e.
>>>> +     */
>>>> +    rtl8xxxu_write8(priv, REG_TXPAUSE, 0x00);
>>>>   }
>>>>     static s8 rtl8192e_cck_rssi(struct rtl8xxxu_priv *priv, u8 cck_agc_rpt)
>>> By the way, you should get this into the stable kernels too:
>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>>
>> I see.
>>
>> But since this patch has not been merged into Linus' tree yet, so should I wait until this patch is merged or I should issue a v2 patch here and Cc it to "table@...r.kernel.org"?
>>
>>
>> Jun ASAKA.
>>
> Ah, yeah. Wait then.

It should be fine to send it now.