netdev - Re: [net 03/10] net/mlx5e: XDP, Allow growing tail for XDP multi buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/j88HQtW/uMZDAh@x130>
Date:   Fri, 24 Feb 2023 10:07:44 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Maxim Mikityanskiy <maxtram95@...il.com>
Subject: Re: [net 03/10] net/mlx5e: XDP, Allow growing tail for XDP multi
 buffer

On 23 Feb 16:34, Jakub Kicinski wrote:
>On Thu, 23 Feb 2023 14:52:40 -0800 Saeed Mahameed wrote:
>> From: Maxim Mikityanskiy <maxtram95@...il.com>
>>
>> The cited commits missed passing frag_size to __xdp_rxq_info_reg, which
>> is required by bpf_xdp_adjust_tail to support growing the tail pointer
>> in fragmented packets. Pass the missing parameter when the current RQ
>> mode allows XDP multi buffer.
>
>Why is this a fix and not an (omitted) feature?

I am sure not intentional, but I agree not critical.