netdev - Re: Choose a default DSA CPU port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230224181621.gri7vlqh44tpjkot@skbuf>
Date:   Fri, 24 Feb 2023 20:16:21 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Frank Wunderlich <frank-w@...lic-files.de>
Cc:     Arınç ÜNAL <arinc.unal@...nc9.com>,
        netdev <netdev@...r.kernel.org>, erkin.bozoglu@...ont.com,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: Choose a default DSA CPU port

On Fri, Feb 24, 2023 at 08:13:26PM +0200, Vladimir Oltean wrote:
> On Fri, Feb 24, 2023 at 07:07:23PM +0100, Frank Wunderlich wrote:
> > root@...-r2:~# ethtool -S eth0 | grep -v ': 0'
> > NIC statistics:
> >      tx_bytes: 1643364546
> >      tx_packets: 1121377
> >      rx_bytes: 1270088499
> >      rx_packets: 1338400
> >      p06_TxUnicast: 1338274
> >      p06_TxMulticast: 120
> >      p06_TxBroadcast: 6
> >      p06_TxPktSz65To127: 525948
> >      p06_TxPktSz128To255: 5
> >      p06_TxPktSz256To511: 16
> >      p06_TxPktSz512To1023: 4
> >      p06_Tx1024ToMax: 812427
> >      p06_TxBytes: 1275442099
> >      p06_RxFiltering: 16
> >      p06_RxUnicast: 1121339
> >      p06_RxMulticast: 37
> >      p06_RxBroadcast: 1
> >      p06_RxPktSz64: 3
> >      p06_RxPktSz65To127: 43757
> >      p06_RxPktSz128To255: 3
> >      p06_RxPktSz256To511: 3
> >      p06_RxPktSz1024ToMax: 1077611
> >      p06_RxBytes: 1643364546
> 
> Looking at the drivers, I see pause frames aren't counted in ethtool -S,
> so we wouldn't know this. However the slowdown *is* lossless, so the
> hypothesis is still not disproved.
> 
> Could you please test after removing the "pause" property from the
> switch's port@6 device tree node?

ah, it is..

static const struct mt7530_mib_desc mt7530_mib[] = {
	MIB_DESC(1, 0x2c, "TxPause"),
};

however it's still good to retest with this variable eliminated.