lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230224115052.5bdcc54d@kernel.org> Date: Fri, 24 Feb 2023 11:50:52 -0800 From: Jakub Kicinski <kuba@...nel.org> To: "Yanchao Yang (杨彦超)" <Yanchao.Yang@...iatek.com> Cc: "Chris Feng (冯保林)" <Chris.Feng@...iatek.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>, "Mingliang Xu (徐明亮)" <mingliang.xu@...iatek.com>, "Min Dong (董敏)" <min.dong@...iatek.com>, "linuxwwan@...el.com" <linuxwwan@...el.com>, "m.chetan.kumar@...el.com" <m.chetan.kumar@...el.com>, "Liang Lu (吕亮)" <liang.lu@...iatek.com>, "Haijun Liu (刘海军)" <haijun.liu@...iatek.com>, "Haozhe Chang (常浩哲)" <Haozhe.Chang@...iatek.com>, "Hua Yang (杨华)" <Hua.Yang@...iatek.com>, "ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>, "Xiayu Zhang (张夏宇)" <Xiayu.Zhang@...iatek.com>, "loic.poulain@...aro.org" <loic.poulain@...aro.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com" <edumazet@...gle.com>, "Ting Wang (王挺)" <ting.wang@...iatek.com>, "johannes@...solutions.net" <johannes@...solutions.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Aiden Wang ( 王咏麒)" <Aiden.Wang@...iatek.com>, "Felix Chen ( 陈非)" <Felix.Chen@...iatek.com>, "Lambert Wang ( 王伟)" <Lambert.Wang@...iatek.com>, "davem@...emloft.net" <davem@...emloft.net>, "Mingchuang Qiao (乔明闯)" <Mingchuang.Qiao@...iatek.com>, "Guohao Zhang (张国豪)" <Guohao.Zhang@...iatek.com> Subject: Re: [PATCH net-next v3 01/10] net: wwan: tmi: Add PCIe core On Fri, 24 Feb 2023 07:39:33 +0000 Yanchao Yang (杨彦超) wrote: > > > Do you really need these flags? > > > > We will check and update if it's really redundant soon. > Update test result. > Both flags are deleted, then run the make command with > "build in" and "build module" on a separate kernel tree. Both suffer > the same build error. > “drivers/net/wan/mediatek/pcie/mtk_pci.c:16:10: fatal error: mtk_fsm.h: > No such file or directory > #include "mtk_fsm.h"" > The reason is that all files are not placed in the same folder. The > driver named TMI needs a child folder, then needs these flags. > > Any ideas or comments for this? Please help share it at your > convenience. Relative paths work, right? > > > Labels should be named after action they perform, not where they > > > jump > > > from. Please fix this everywhere. > > > > We can found similar samples in kernel codes, naming the label per > > where jump from… > > ex. pci-sysfs.c > > shall we apply this rule to our driver? > > I > > t's mandatory or nice to have. > > Any ideas or comments for this? Please help share it at your > convenience. It's mandatory for new code.
Powered by blists - more mailing lists