netdev - Re: [intel-net] ice: remove unnecessary CONFIG_ICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <399301ca-7424-b0b1-edd8-885351b8d5f4@intel.com>
Date:   Thu, 23 Feb 2023 16:32:12 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>,
        <netdev@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Anthony Nguyen <anthony.l.nguyen@...el.com>
Subject: Re: [intel-net] ice: remove unnecessary CONFIG_ICE_GNSS



On 2/23/2023 4:13 PM, Jakub Kicinski wrote:
> On Thu, 23 Feb 2023 14:55:07 -0800 Jacob Keller wrote:
>>> I mean instead of s/IS_ENABLED/IS_REACHABLE/ do this:
>>>
>>> index 3facb55b7161..198995b3eab5 100644
>>> --- a/drivers/net/ethernet/intel/Kconfig
>>> +++ b/drivers/net/ethernet/intel/Kconfig
>>> @@ -296,6 +296,7 @@ config ICE
>>>         default n
>>>         depends on PCI_MSI
>>>         depends on PTP_1588_CLOCK_OPTIONAL
>>> +       depends on GNSS || GNSS=n
>>>         select AUXILIARY_BUS
>>>         select DIMLIB
>>>         select NET_DEVLINK
>>>
>>> Or do you really care about building ICE with no GNSS.. ?  
>>
>> This would probably also work, but you'd still need #if IS_ENABLED in
>> ice_gnss.h to split the stub functions when GNSS is disabled.
>>
>> The original author, Arkadiusz, can comment on whether we care about
>> building without GNSS support.
>>
>> My guess its a "we don't need it for core functionality, so we don't
>> want to block building ice if someone doesn't want GNSS for whatever
>> reason."
> 
> Just to be crystal clear we're talking about the GNSS=m ICE=y case.
> I'm suggesting that it should be disallowed at the Kconfig level.
> ICE=m/y GNSS=n will still work as expected.

Fair enough. I guess I would expect "ICE=y, GNSS=m" to just have ice not
support GNSS. But disallowing it is fine as well. I can see how that
might be confusing to others.

I can make that change with the dependency.

Thanks,
Jake