[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <167723417226.18267.13778224357236866036.kvalo@kernel.org>
Date: Fri, 24 Feb 2023 10:22:55 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Loic Poulain <loic.poulain@...aro.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next] wifi: wcn36xx: Slightly optimize
PREPARE_HAL_BUF()
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:
> In most (likely all) cases, INIT_HAL_MSG() is called before
> PREPARE_HAL_BUF().
> In such cases calling memset() is useless because:
> msg_body.header.len = sizeof(msg_body)
>
> So, instead of writing twice the memory, we just have a sanity check to
> make sure that some potential trailing memory is zeroed.
> It even gives the opportunity to see that by itself and optimize it away.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Acked-by: Loic Poulain <loic.poulain@...aro.org>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>
Patch applied to ath-next branch of ath.git, thanks.
4a51e66fe96d wifi: wcn36xx: Slightly optimize PREPARE_HAL_BUF()
--
https://patchwork.kernel.org/project/linux-wireless/patch/7d8ab7fee45222cdbaf80c507525f2d3941587c1.1675371372.git.christophe.jaillet@wanadoo.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists