netdev - Re: [PATCH] can: esd_usb: Improve code readability by means of replacing struct esd_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZ6RqJwJNxn5nm-PW2yY3BobTNB+vVmeDGi=M80YavN8Ui-OQ@mail.gmail.com>
Date:   Sat, 25 Feb 2023 17:34:37 +0900
From:   Vincent MAILHOL <mailhol.vincent@...adoo.fr>
To:     Frank Jungclaus <frank.jungclaus@....eu>
Cc:     linux-can@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Stefan Mätje <stefan.maetje@....eu>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: esd_usb: Improve code readability by means of
 replacing struct esd_usb_msg with a union

On Thu. 23 Feb. 2023 at 01:56, Frank Jungclaus <frank.jungclaus@....eu> wrote:
> As suggested by Vincent Mailhol, declare struct esd_usb_msg as a union
> instead of a struct. Then replace all msg->msg.something constructs,
> that make use of esd_usb_msg, with simpler and prettier looking
> msg->something variants.
>
> Link: https://lore.kernel.org/all/CAMZ6RqKRzJwmMShVT9QKwiQ5LJaQupYqkPkKjhRBsP=12QYpfA@mail.gmail.com/
> Suggested-by: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
> Signed-off-by: Frank Jungclaus <frank.jungclaus@....eu>

Thank you for your follow up on this and on all my other comments.

Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>