| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <trinity-3a190e81-4797-4428-881b-7fb6dd2b19f5-1677323664480@3c-app-gmx-bap06>
Date: Sat, 25 Feb 2023 12:14:24 +0100
From: Frank Wunderlich <frank-w@...lic-files.de>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Arınç ÜNAL <arinc.unal@...nc9.com>,
netdev <netdev@...r.kernel.org>, erkin.bozoglu@...ont.com,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>,
Mark Lee <Mark-MC.Lee@...iatek.com>,
Lorenzo Bianconi <lorenzo@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Landen Chao <Landen.Chao@...iatek.com>,
Sean Wang <sean.wang@...iatek.com>,
DENG Qingfang <dqfext@...il.com>
Subject: Aw: Re: Choose a default DSA CPU port
> Gesendet: Freitag, 24. Februar 2023 um 22:08 Uhr
> Von: "Vladimir Oltean" <olteanv@...il.com>
> An: "Frank Wunderlich" <frank-w@...lic-files.de>
> Cc: "Arınç ÜNAL" <arinc.unal@...nc9.com>, "netdev" <netdev@...r.kernel.org>, erkin.bozoglu@...ont.com, "Andrew Lunn" <andrew@...n.ch>, "Florian Fainelli" <f.fainelli@...il.com>, "Felix Fietkau" <nbd@....name>, "John Crispin" <john@...ozen.org>, "Mark Lee" <Mark-MC.Lee@...iatek.com>, "Lorenzo Bianconi" <lorenzo@...nel.org>, "Matthias Brugger" <matthias.bgg@...il.com>, "Landen Chao" <Landen.Chao@...iatek.com>, "Sean Wang" <sean.wang@...iatek.com>, "DENG Qingfang" <dqfext@...il.com>
> Betreff: Re: Choose a default DSA CPU port
>
> On Fri, Feb 24, 2023 at 09:44:43PM +0100, Frank Wunderlich wrote:
> > 6.1.12 is clean and i get 940 Mbit/s over gmac0/port6
>
> Sounds like something which could be bisected?
tried this, and got network completely broken on third step
git bisect start
# good: [830b3c68c1fb1e9176028d02ef86f3cf76aa2476] Linux 6.1
git bisect good 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
# bad: [c9c3395d5e3dcc6daee66c6908354d47bf98cb0c] Linux 6.2
git bisect bad c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
# good: [1ca06f1c1acecbe02124f14a37cce347b8c1a90c] Merge tag 'xtensa-20221213' of https://github.com/jcmvbkbc/linux-xtensa
git bisect good 1ca06f1c1acecbe02124f14a37cce347b8c1a90c
$ git logone -1
b83a7080d300 2022-12-16 Merge tag 'staging-6.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging (HEAD)
wan and eth0 are up, but no traffic :(
root@...-r2:~# ip link set eth0 up
[ 259.865441] mtk_soc_eth 1b100000.ethernet eth0: configuring for fixed/trgmii
link mode
[ 259.873639] mtk_soc_eth 1b100000.ethernet eth0: Link is Up - 1Gbps/Full - flo
w control rx/tx
[ 259.882175] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
root@...-r2:~#
root@...-r2:~# ip link set wan up
[ 269.651154] mt7530 mdio-bus:00 wan: configuring for phy/gmii link mode
root@...-r2:~# [ 272.742227] mt7530 mdio-bus:00 wan: Link is Up - 1Gbps/Full -
flow control rx/tx
[ 272.749678] IPv6: ADDRCONF(NETDEV_CHANGE): wan: link becomes ready
root@...-r2:~# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group defaul
t qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1504 qdisc mq state UP group defa
ult qlen 1000
link/ether 3a:69:cb:48:04:40 brd ff:ff:ff:ff:ff:ff
inet6 fe80::3869:cbff:fe48:440/64 scope link
valid_lft forever preferred_lft forever
3: sit0@...E: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
link/sit 0.0.0.0 brd 0.0.0.0
4: wan@...0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP g
roup default qlen 1000
link/ether 08:22:33:44:55:77 brd ff:ff:ff:ff:ff:ff
inet 192.168.0.11/24 scope global wan
valid_lft forever preferred_lft forever
inet6 fe80::a22:33ff:fe44:5577/64 scope link
valid_lft forever preferred_lft forever
5: lan0@...0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default
qlen 1000
link/ether 3a:5d:98:f7:50:8b brd ff:ff:ff:ff:ff:ff
6: lan1@...0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default
qlen 1000
link/ether 3e:de:03:53:13:70 brd ff:ff:ff:ff:ff:ff
7: lan2@...0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default
qlen 1000
link/ether 66:8a:45:e7:49:14 brd ff:ff:ff:ff:ff:ff
8: lan3@...0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default
qlen 1000
link/ether 0a:81:22:f8:21:57 brd ff:ff:ff:ff:ff:ff
root@...-r2:~#
root@...-r2:~#
root@...-r2:~#
root@...-r2:~# ping 192.168.0.21
PING 192.168.0.21 (192.168.0.21) 56(84) bytes of data.
>From 192.168.0.11 icmp_seq=1 Destination Host Unreachable
>From 192.168.0.11 icmp_seq=2 Destination Host Unreachable
>From 192.168.0.11 icmp_seq=3 Destination Host Unreachable
^C
--- 192.168.0.21 ping statistics ---
4 packets transmitted, 0 received, +3 errors, 100% packet loss, time 3111ms
pipe 4
root@...-r2:~# ethtool eth0
Settings for eth0:
Supported ports: [ MII ]
Supported link modes: 1000baseT/Full
Supported pause frame use: Symmetric Receive-only
Supports auto-negotiation: Yes
Supported FEC modes: Not reported
Advertised link modes: 1000baseT/Full
Advertised pause frame use: Symmetric Receive-only
Advertised auto-negotiation: Yes
Advertised FEC modes: Not reported
Link partner advertised link modes: 1000baseT/Full
Link partner advertised pause frame use: Symmetric
Link partner advertised auto-negotiation: No
Link partner advertised FEC modes: Not reported
Speed: 1000Mb/s
Duplex: Full
Auto-negotiation: on
Port: MII
PHYAD: 0
Transceiver: internal
Current message level: 0x000000ff (255)
drv probe link timer ifdown ifup rx_err tx_err
Link detected: yes
root@...-r2:~# ethtool -S eth0
NIC statistics:
tx_bytes: 7342
tx_packets: 90
tx_skip: 0
tx_collisions: 0
rx_bytes: 9980
rx_packets: 105
rx_overflow: 0
rx_fcs_errors: 0
rx_short_errors: 0
rx_long_errors: 0
rx_checksum_errors: 0
rx_flow_control_packets: 0
rx_xdp_redirect: 0
rx_xdp_pass: 0
rx_xdp_drop: 0
rx_xdp_tx: 0
rx_xdp_tx_errors: 0
tx_xdp_xmit: 0
tx_xdp_xmit_errors: 0
p06_TxDrop: 0
p06_TxCrcErr: 0
p06_TxUnicast: 21
p06_TxMulticast: 80
p06_TxBroadcast: 4
p06_TxCollision: 0
p06_TxSingleCollision: 0
p06_TxMultipleCollision: 0
p06_TxDeferred: 0
p06_TxLateCollision: 0
p06_TxExcessiveCollistion: 0
p06_TxPause: 0
p06_TxPktSz64: 0
p06_TxPktSz65To127: 93
p06_TxPktSz128To255: 4
p06_TxPktSz256To511: 8
p06_TxPktSz512To1023: 0
p06_Tx1024ToMax: 0
p06_TxBytes: 10400
p06_RxDrop: 0
p06_RxFiltering: 30
p06_RxUnicast: 0
p06_RxMulticast: 69
p06_RxBroadcast: 21
p06_RxAlignErr: 0
p06_RxCrcErr: 0
p06_RxUnderSizeErr: 0
p06_RxFragErr: 0
p06_RxOverSzErr: 0
p06_RxJabberErr: 0
p06_RxPause: 0
p06_RxPktSz64: 25
p06_RxPktSz65To127: 65
p06_RxPktSz128To255: 0
p06_RxPktSz256To511: 0
p06_RxPktSz512To1023: 0
p06_RxPktSz1024ToMax: 0
p06_RxBytes: 7342
p06_RxCtrlDrop: 0
p06_RxIngressDrop: 0
p06_RxArlDrop: 0
root@...-r2:~# ethtool -S wan
NIC statistics:
tx_packets: 60
tx_bytes: 3932
rx_packets: 10
rx_bytes: 1848
TxDrop: 0
TxCrcErr: 0
TxUnicast: 0
TxMulticast: 39
TxBroadcast: 21
TxCollision: 0
TxSingleCollision: 0
TxMultipleCollision: 0
TxDeferred: 0
TxLateCollision: 0
TxExcessiveCollistion: 0
TxPause: 0
TxPktSz64: 25
TxPktSz65To127: 35
TxPktSz128To255: 0
TxPktSz256To511: 0
TxPktSz512To1023: 0
Tx1024ToMax: 0
TxBytes: 4574
RxDrop: 0
RxFiltering: 0
RxUnicast: 21
RxMulticast: 86
RxBroadcast: 4
RxAlignErr: 0
RxCrcErr: 0
RxUnderSizeErr: 0
RxFragErr: 0
RxOverSzErr: 0
RxJabberErr: 0
RxPause: 0
RxPktSz64: 91
RxPktSz65To127: 12
RxPktSz128To255: 0
RxPktSz256To511: 8
RxPktSz512To1023: 0
RxPktSz1024ToMax: 0
RxBytes: 10364
RxCtrlDrop: 0
RxIngressDrop: 0
RxArlDrop: 0
root@...-r2:~#
checked commits at this point for mt7530 dsa driver and mtk-eth driver, first has no changes, but mediatek-driver has a bunch of commits which may break...most of them are wed-specific which is not available/enabled on mt7623.
$ git logone -20 -- drivers/net/ethernet/mediatek/
587585e1bbeb 2022-12-07 net: ethernet: mtk_wed: fix possible deadlock if mtk_wed_wo_init fails
c79e0af5ae5e 2022-12-07 net: ethernet: mtk_wed: fix some possible NULL pointer dereferences
e22dcbc9aa32 2022-12-05 net: ethernet: mtk_wed: Fix missing of_node_put() in mtk_wed_wo_hardware_init()
ed883bec679b 2022-12-05 net: ethernet: mtk_wed: add reset to rx_ring_setup callback
c9f8d73645b6 2022-12-03 net: mtk_eth_soc: enable flow offload support for MT7986 SoC
65e6af6cebef 2022-12-01 net: ethernet: mtk_wed: fix sleep while atomic in mtk_wed_wo_queue_refill
f2bb566f5c97 2022-11-29 Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
23dca7a90017 2022-11-24 net: ethernet: mtk_wed: add reset to tx_ring_setup callback
b08134c6e109 2022-11-24 net: ethernet: mtk_wed: add mtk_wed_rx_reset routine
f78cd9c783e0 2022-11-24 net: ethernet: mtk_wed: update mtk_wed_stop
92b1169660eb 2022-11-24 net: ethernet: mtk_wed: move MTK_WDMA_RESET_IDX_TX configuration in mtk_wdma_tx_reset
b0488c4598a5 2022-11-24 net: ethernet: mtk_wed: return status value in mtk_wdma_rx_reset
a66d79ee0bd5 2022-11-24 net: ethernet: mtk_wed: add wcid overwritten support for wed v1
603ea5e7ffa7 2022-11-20 net: ethernet: mtk_eth_soc: fix memory leak in error path <<<<<<< in 6.1 from here
8110437e5961 2022-11-20 net: ethernet: mtk_eth_soc: fix resource leak in error path
3213f808ae21 2022-11-20 net: ethernet: mtk_eth_soc: fix potential memory leak in mtk_rx_alloc()
ef8c373bd91d 2022-11-17 net: ethernet: mtk_eth_soc: fix RSTCTRL_PPE{0,1} definitions
8bd8dcc5e47f 2022-11-16 net: ethernet: mediatek: ppe: assign per-port queues for offloaded traffic
f63959c7eec3 2022-11-16 net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues
71ba8e4891c7 2022-11-16 net: ethernet: mtk_eth_soc: avoid port_mg assignment on MT7622 and newer
frank@...nk-G5:/media/data_nvme/git/kernel/BPI-R2-4.14 (HEAD) [1M46U]
$ git logone -10 v6.1 -- drivers/net/ethernet/mediatek/
603ea5e7ffa7 2022-11-20 net: ethernet: mtk_eth_soc: fix memory leak in error path
8110437e5961 2022-11-20 net: ethernet: mtk_eth_soc: fix resource leak in error path
3213f808ae21 2022-11-20 net: ethernet: mtk_eth_soc: fix potential memory leak in mtk_rx_alloc()
f70074140524 2022-11-17 net: ethernet: mtk_eth_soc: fix error handling in mtk_open()
b0c09c7f08c2 2022-11-07 net: ethernet: mtk-star-emac: disable napi when connect and start PHY failed in mtk_star_enable()
402fe7a57287 2022-10-17 net: ethernet: mediatek: ppe: Remove the unused function mtk_foe_entry_usable()
e0bb4659e235 2022-10-17 net: ethernet: mtk_eth_wed: add missing of_node_put()
9d4f20a476ca 2022-10-17 net: ethernet: mtk_eth_wed: add missing put_device() in mtk_wed_add_hw()
b3d0d98179d6 2022-10-17 net: ethernet: mtk_eth_soc: fix possible memory leak in mtk_probe()
4af609b216e8 2022-10-06 net: ethernet: mediatek: Remove -Warray-bounds exception
$ git logone -10 drivers/net/dsa/mt7530.c
accc3b4a572b 2022-09-29 Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
728c2af6ad8c 2022-09-17 net: mt7531: ensure all MACs are powered down before reset
42bc4fafe359 2022-09-17 net: mt7531: only do PLL once after the reset
e19de30d2080 2022-09-21 net: dsa: mt7530: add support for in-band link status
ebe48922c0c4 2022-09-21 net: dsa: mt7530: remove unnecessary dev_set_drvdata()
1f9a6abecf53 2022-06-10 net: dsa: mt7530: get cpu-port via dp->cpu_dp instead of constant
6e19bc26cccd 2022-06-10 net: dsa: mt7530: rework mt753[01]_setup
a9c317417c27 2022-06-10 net: dsa: mt7530: rework mt7530_hw_vlan_{add,del}
c8227d568ddf 2022-05-05 Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
a9e9b091a1c1 2022-04-28 net: dsa: mt7530: add missing of_node_put() in mt7530_setup()
Powered by blists - more mailing lists