netdev - Re: [PATCH RFC net-next 3/4] net: mtk_eth_soc: remove unnecessary checks in mtk_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/o7sJ8YZZqI09U0@corigine.com>
Date:   Sat, 25 Feb 2023 17:47:44 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     Daniel Golle <daniel@...rotopia.org>, Felix Fietkau <nbd@....name>,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH RFC net-next 3/4] net: mtk_eth_soc: remove unnecessary
 checks in mtk_mac_config()

On Fri, Feb 24, 2023 at 12:36:21PM +0000, Russell King (Oracle) wrote:
> mtk_mac_config() checks that the interface mode is permitted for the
> capabilities, but we already do these checks in mtk_add_mac() when
> initialising phylink's supported_interfaces bitmap. Remove the
> unnecessary tests.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Simon Horman <simon.horman@...igine.com>