[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230226095933.3286710-1-void0red@gmail.com>
Date: Sun, 26 Feb 2023 17:59:33 +0800
From: Kang Chen <void0red@...il.com>
To: krzysztof.kozlowski@...aro.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Kang Chen <void0red@...il.com>
Subject: [PATCH] nfc: fdp: add null check of devm_kmalloc_array in fdp_nci_i2c_read_device_properties
devm_kmalloc_array may fails, *fw_vsc_cfg might be null and cause
out-of-bounds write in device_property_read_u8_array later.
Signed-off-by: Kang Chen <void0red@...il.com>
---
drivers/nfc/fdp/i2c.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c
index 2d53e0f88..d95d20efa 100644
--- a/drivers/nfc/fdp/i2c.c
+++ b/drivers/nfc/fdp/i2c.c
@@ -247,6 +247,9 @@ static void fdp_nci_i2c_read_device_properties(struct device *dev,
len, sizeof(**fw_vsc_cfg),
GFP_KERNEL);
+ if (!*fw_vsc_cfg)
+ goto vsc_read_err;
+
r = device_property_read_u8_array(dev, FDP_DP_FW_VSC_CFG_NAME,
*fw_vsc_cfg, len);
--
2.34.1
Powered by blists - more mailing lists