lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20230226145123.829229-19-sashal@kernel.org> Date: Sun, 26 Feb 2023 09:51:21 -0500 From: Sasha Levin <sashal@...nel.org> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: Moshe Shemesh <moshe@...dia.com>, Jiri Pirko <jiri@...dia.com>, Jakub Kicinski <kuba@...nel.org>, Sasha Levin <sashal@...nel.org>, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, idosch@...dia.com, jacob.e.keller@...el.com, michal.wilczynski@...el.com, vikas.gupta@...adcom.com, shayd@...dia.com, netdev@...r.kernel.org Subject: [PATCH AUTOSEL 5.4 19/19] devlink: health: Fix nla_nest_end in error flow From: Moshe Shemesh <moshe@...dia.com> [ Upstream commit bfd4e6a5dbbc12f77620602e764ac940ccb159de ] devlink_nl_health_reporter_fill() error flow calls nla_nest_end(). Fix it to call nla_nest_cancel() instead. Note the bug is harmless as genlmsg_cancel() cancel the entire message, so no fixes tag added. Signed-off-by: Moshe Shemesh <moshe@...dia.com> Reviewed-by: Jiri Pirko <jiri@...dia.com> Reviewed-by: Jakub Kicinski <kuba@...nel.org> Signed-off-by: Jakub Kicinski <kuba@...nel.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 2dd354d869cd7..c6fef33d5d6d4 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -4991,7 +4991,7 @@ devlink_nl_health_reporter_fill(struct sk_buff *msg, return 0; reporter_nest_cancel: - nla_nest_end(msg, reporter_attr); + nla_nest_cancel(msg, reporter_attr); genlmsg_cancel: genlmsg_cancel(msg, hdr); return -EMSGSIZE; -- 2.39.0
Powered by blists - more mailing lists