netdev - Re: [PATCH] [net] add rx_otherhost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230227102339.08ddf3fb@kernel.org>
Date:   Mon, 27 Feb 2023 10:23:39 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     nick black <dankamongmen@...il.com>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jeffrey Ji <jeffreyji@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH] [net] add rx_otherhost_dropped sysfs entry

On Sat, 25 Feb 2023 16:12:16 -0500 nick black wrote:
> Add the sysfs export for rx_otherhost_dropped, added
> in 794c24e9921f ("rx_otherhost_dropped to core_stats").
> All other rtnl_link_stats64 entries are already present
> as sysfs nodes; this completes the set.

"All the other stats are there" is not a strong enough reason
to waste memory on all systems. You need to justify the change
based on how important the counter is. I'd prefer to draw a
line on adding the sysfs stats entries. We don't want to have 
to invent a new stats struct just to avoid having sysfs entries
for each stat.