netdev - Re: [PATCH net 1/1] ice: remove unnecessary CONFIG_ICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230227115858.72c0ecd9@kernel.org>
Date:   Mon, 27 Feb 2023 11:58:58 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        netdev@...r.kernel.org, Jacob Keller <jacob.e.keller@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
        Alexander Lobakin <alexandr.lobakin@...el.com>
Subject: Re: [PATCH net 1/1] ice: remove unnecessary CONFIG_ICE_GNSS

On Fri, 24 Feb 2023 13:32:41 -0800 Tony Nguyen wrote:
> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> CONFIG_ICE_GNSS was added by commit c7ef8221ca7d ("ice: use GNSS subsystem
> instead of TTY") as a way to allow the ice driver to optionally support
> GNSS features without forcing a dependency on CONFIG_GNSS.
> 
> The original implementation of that commit at [1] used IS_REACHABLE. This
> was rejected by Olek at [2] with the suggested implementation of
> CONFIG_ICE_GNSS.
> 
> Eventually after merging, Linus reported a .config which had
> CONFIG_ICE_GNSS = y when both GNSS = n and ICE = n. This confused him and
> he felt that the config option was not useful, and commented about it at
> [3].

Applied, thanks!