netdev - Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7085019b-4fad-4d8d-89c0-1dd33fb27bb7@app.fastmail.com>
Date:   Mon, 27 Feb 2023 22:30:08 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Larry Finger" <Larry.Finger@...inger.net>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Dominik Brodowski" <linux@...inikbrodowski.net>,
        linux-kernel@...r.kernel.org
Cc:     "Bjorn Helgaas" <bhelgaas@...gle.com>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        "Hartley Sweeten" <hsweeten@...ionengravers.com>,
        "Ian Abbott" <abbotti@....co.uk>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Kevin Cernekee" <cernekee@...il.com>,
        "Lukas Wunner" <lukas@...ner.de>,
        "Manuel Lauss" <manuel.lauss@...il.com>,
        "Oliver Hartkopp" <socketcan@...tkopp.net>,
        "Olof Johansson" <olof@...om.net>,
        "Robert Jarzmik" <robert.jarzmik@...e.fr>,
        "YOKOTA Hiroshi" <yokota@...lab.is.tsukuba.ac.jp>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-can@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-wireless@...r.kernel.org, Netdev <netdev@...r.kernel.org>
Subject: Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus

On Mon, Feb 27, 2023, at 22:09, Larry Finger wrote:
> On 2/27/23 14:38, Arnd Bergmann wrote:
>> Is this the Cardbus or the PCMCIA version of the BCM4306 device? As far
>> as I understand this particular chip can be wired up either way inside
>> of the card, and the PowerBook G4 supports both types of devices.
>> 
>> If it's the PCMCIA version, then dropping support for it was the idea
>> of the patch series that we can debate, but if it was the Cardbus version
>> that broke, then this was likely a bug I introduced by accident.
>
> The BCM4306 is internal, and wired directly to the PCI bus. My understanding is 
> that the BCM4318 is a cardbus device. It definitely shows up in an lspci scan.

Ah right, I got confused because I had googled for BCM4306 for too long
trying to find out whether that might be used in combination with the
BCM63xx SoC support that patch 1 removed.

BCM4318 should definitely keep working after my series. My best guess
is that the problem is that I introduced an unnecessary dependency
between CONFIG_CARDBUS and CONFIG_PCI_HOTPLUG, so you'd need to
either undo the dependency or enable both in the local config.

If it's not that, then it's a bug in my changes that needs to be
fixed before they can be considered for integration. As long as
we are still debating whether the series makes sense at all,
I'm not worried about this.

      Arnd