netdev - Re: [PATCH] netfilter: nf_tables: always synchronize with readers before releasing tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230227233155.GA6107@breakpoint.cc>
Date:   Tue, 28 Feb 2023 00:31:55 +0100
From:   Florian Westphal <fw@...len.de>
To:     Alexander Atanasov <alexander.atanasov@...tuozzo.com>
Cc:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] netfilter: nf_tables: always synchronize with readers
 before releasing tables

Alexander Atanasov <alexander.atanasov@...tuozzo.com> wrote:
> As i said i am still trying to figure out the basechain place,
> where is that synchronize_rcu() call done?

cleanup_net() in net/core/net_namespace.c.

pre_exit handlers run, then synchronize_rcu, then the
normal exit handlers, then exit_batch.

> > Do you see this with current kernels or did the splat happen with
> > an older version?
> 
> It's with a bit older kernel but there is no significant difference
> wrt nf_tables_api code.
> I will prepare a more detailed report for you.

Thanks.