lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230227101112.GB24064@pengutronix.de> Date: Mon, 27 Feb 2023 11:11:12 +0100 From: Oleksij Rempel <o.rempel@...gutronix.de> To: Dan Carpenter <error27@...il.com> Cc: Oleksij Rempel <linux@...pel-privat.de>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH net] net: phy: unlock on error in phy_probe() On Mon, Feb 27, 2023 at 01:03:22PM +0300, Dan Carpenter wrote: > If genphy_c45_read_eee_adv() fails then we need to do a reset and unlock > the &phydev->lock mutex before returning. > > Fixes: 3eeca4e199ce ("net: phy: do not force EEE support") > Signed-off-by: Dan Carpenter <error27@...il.com> Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de> Thank you! > --- > drivers/net/phy/phy_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 3f8a64fb9d71..9e9fd8ff00f6 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -3146,7 +3146,7 @@ static int phy_probe(struct device *dev) > */ > err = genphy_c45_read_eee_adv(phydev, phydev->advertising_eee); > if (err) > - return err; > + goto out; > > /* There is no "enabled" flag. If PHY is advertising, assume it is > * kind of enabled. > -- > 2.39.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists