netdev - Re: [PATCH] soc:tegra:pmc: Add wake source interrupt for mgbe.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b8de64a-dc55-8ed4-857b-9d524951760d@nvidia.com>
Date:   Mon, 27 Feb 2023 13:34:55 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Sushil Singh <sushilkumars@...dia.com>, thierry.reding@...il.com
Cc:     linux-tegra@...r.kernel.org, netdev@...r.kernel.org,
        vbhadram@...dia.com
Subject: Re: [PATCH] soc:tegra:pmc: Add wake source interrupt for mgbe.



On 16/01/2023 10:19, Sushil Singh wrote:
> Add mgbe ethernet GPIO wake interrupt

Add the GPIO wake interrupt for the MGBE ethernet controller on Tegra234 
devices.

> 
> Signed-off-by: Sushil Singh <sushilkumars@...dia.com>
> ---
>   drivers/soc/tegra/pmc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index cf4cfbf..f4abc7f 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3,7 +3,7 @@
>    * drivers/soc/tegra/pmc.c
>    *
>    * Copyright (c) 2010 Google, Inc
> - * Copyright (c) 2018-2022, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
>    *
>    * Author:
>    *	Colin Cross <ccross@...gle.com>
> @@ -4227,6 +4227,7 @@ static const char * const tegra234_reset_sources[] = {
>   static const struct tegra_wake_event tegra234_wake_events[] = {
>   	TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
>   	TEGRA_WAKE_IRQ("rtc", 73, 10),
> +	TEGRA_WAKE_GPIO("mgbe_wake", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),

Just 'mgbe' is sufficient.

>   };
>   
>   static const struct tegra_pmc_soc tegra234_pmc_soc = {

Please check the subject prefix for the subsystem by looking at the git 
history ...

$ git log --oneline drivers/soc/tegra/pmc.c
0474cc8489bd soc/tegra: pmc: Process wake events during resume
1ddb8f6d44ff soc/tegra: pmc: Fix dual edge triggered wakes
c9c4ddb20c42 soc/tegra: pmc: Add I/O pad table for Tegra234
74f7f183d81c soc/tegra: pmc: Check device node status property
...

So the subject should start "soc/tegra: pmc: ". Also remove the '.' from 
the end of the subject.

Finally, please use 'MGBE' in the subject and description.

Jon

-- 
nvpublic