netdev - Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2023 09:37:21 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Larry Finger" <Larry.Finger@...inger.net>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Dominik Brodowski" <linux@...inikbrodowski.net>,
        linux-kernel@...r.kernel.org
Cc:     "Bjorn Helgaas" <bhelgaas@...gle.com>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        "Hartley Sweeten" <hsweeten@...ionengravers.com>,
        "Ian Abbott" <abbotti@....co.uk>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Kevin Cernekee" <cernekee@...il.com>,
        "Lukas Wunner" <lukas@...ner.de>,
        "Manuel Lauss" <manuel.lauss@...il.com>,
        "Oliver Hartkopp" <socketcan@...tkopp.net>,
        "Olof Johansson" <olof@...om.net>,
        "Robert Jarzmik" <robert.jarzmik@...e.fr>,
        "YOKOTA Hiroshi" <yokota@...lab.is.tsukuba.ac.jp>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-can@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-wireless@...r.kernel.org, Netdev <netdev@...r.kernel.org>
Subject: Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus

On Tue, Feb 28, 2023, at 04:57, Larry Finger wrote:
> On 2/27/23 15:30, Arnd Bergmann wrote:
>
> It was a configuration problem. In the .config obtained by installing 
> your 
> patches, and doing a make, CONFIG_CARDBUS was not mentioned, and 
> CONFIG_PCI_HOTPLUG was not selected. When I deleted the reference to 
> the latter, 
> did a make, and set ..._HOTPLUG, I got CONFIG+CARDBUS set to "m", and 
> the yenta 
> modules were built. This version sees the BCM4318 in the lspci scan, 
> and the 
> interface works. Your patches are OK.

Ok, great, thanks for testing!

> I am not sure how to warn people about the configuration change possible 
> breaking things.

My intention was to keep Cardbus support working with old defconfig files,
and I've not moved CONFIG_CARDBUS into a separate submenu between
CONFIG_PCI_HOTPLUG and CONFIG_PCI_CONTROLLER but left the driver in
drivers/pci/hotplug. I think that's the best compromise here, but maybe
the PCI maintainers have a better idea.

     Arnd