netdev - Re: [PATCH iproute2] u32: fix TC_U32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoM=-sSuZbgjEH_KH8WTqTXYSagN0E6JLF+MKBFDSG_z9Hw@mail.gmail.com>
Date:   Tue, 28 Feb 2023 05:55:30 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2] u32: fix TC_U32_TERMINAL printing

Hangbin,
Can you please run tdc tests on all tc (both for iproute2 and kernel)
changes you make and preferably show them in the commit log? If you
introduce something new then add a new tdc test case to cover it.

cheers,
jamal

On Mon, Feb 27, 2023 at 10:50 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> We previously printed an asterisk if there was no 'sel' or 'TC_U32_TERMINAL'
> flag. However, commit 1ff22754 ("u32: fix json formatting of flowid")
> changed the logic to print an asterisk only if there is a 'TC_U32_TERMINAL'
> flag. Therefore, we need to fix this regression.
>
> Fixes: 1ff227545ce1 ("u32: fix json formatting of flowid")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tc/f_u32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tc/f_u32.c b/tc/f_u32.c
> index bfe9e5f9..de2d0c9e 100644
> --- a/tc/f_u32.c
> +++ b/tc/f_u32.c
> @@ -1273,7 +1273,7 @@ static int u32_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt,
>         if (tb[TCA_U32_CLASSID]) {
>                 __u32 classid = rta_getattr_u32(tb[TCA_U32_CLASSID]);
>                 SPRINT_BUF(b1);
> -               if (sel && (sel->flags & TC_U32_TERMINAL))
> +               if (!sel || !(sel->flags & TC_U32_TERMINAL))
>                         print_string(PRINT_FP, NULL, "*", NULL);
>
>                 print_string(PRINT_ANY, "flowid", "flowid %s ",
> --
> 2.38.1
>