netdev - Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable bcntime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2023 12:06:58 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     pkshih@...ltek.com, kvalo@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable
 bcntime_cfg

On Tue, Feb 28, 2023 at 10:11:32AM +0800, Jiapeng Chong wrote:
> Variable bcntime_cfg is not effectively used, so delete it.
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:6: warning: variable 'bcntime_cfg' set but not used.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4240
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Hi Jiapeng Chong,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>

While reviewing this gcc 12.2.0 told me:

drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:25: error: unused variable 'bcn_ifs' [-Werror=unused-variable]
 1555 |         u16 bcn_cw = 6, bcn_ifs = 0xf;
      |                         ^~~~~~~
drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:13: error: unused variable 'bcn_cw' [-Werror=unused-variable]
 1555 |         u16 bcn_cw = 6, bcn_ifs = 0xf;
      |             ^~~~~~

So perhaps you could consider sending another patch to remove them too.