netdev - Re: [PATCH net] tls: rx: fix return value for async crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/3kZDAzhTT4RlYY@corigine.com>
Date:   Tue, 28 Feb 2023 12:24:20 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, gaurav.jain@....com, borisp@...dia.com,
        john.fastabend@...il.com
Subject: Re: [PATCH net] tls: rx: fix return value for async crypto

On Mon, Feb 27, 2023 at 10:12:01AM -0800, Jakub Kicinski wrote:
> Gaurav reports that TLS Rx is broken with async crypto
> accelerators. The commit under fixes missed updating
> the retval byte counting logic when updating how records
> are stored. Even tho both before and after the change
> 'decrypted' was updated inside the main loop, it was
> completely overwritten when processing the async
> completions. Now that the rx_list only holds
> non-zero-copy records we need to add, not overwrite.
> 
> Reported-and-bisected-by: Gaurav Jain <gaurav.jain@....com>
> Fixes: cbbdee9918a2 ("tls: rx: async: don't put async zc on the list")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217064
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <simon.horman@...igine.com>