netdev - Re: [PATCH v2] net: lan743x: LAN743X selects FIXED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <192d72313269845fe19d6d8baecbecfb9d184f77.camel@redhat.com>
Date:   Tue, 28 Feb 2023 12:50:17 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Tom Rix <trix@...hat.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, steen.hegelund@...rochip.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a
 link error

Hello,

On Mon, 2023-02-27 at 08:05 -0500, Tom Rix wrote:
> A rand config causes this link error
> drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open':
> drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register'
> 
> lan743x_netdev_open is controlled by LAN743X
> fixed_phy_register is controlled by FIXED_PHY
> 
> and the error happens when
> CONFIG_LAN743X=y
> CONFIG_FIXED_PHY=m
> 
> So LAN743X should also select FIXED_PHY
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

You are targeting the -net tree, but this lacks a 'Fixes' tag, please
post a new version with such info.

If instead the intended target was net-next (as I think it was agreed
on previous revision) please repost after that net-next re-opens (in
~1w from now).

Thanks,

Paolo