netdev - Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support [multicast/DSA issues]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230301170408.0cc0519d@kmaincent-XPS-13-7390>
Date:   Wed, 1 Mar 2023 17:04:08 +0100
From:   Köry Maincent <kory.maincent@...tlin.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "Russell King (Oracle)" <linux@...linux.org.uk>,
        Richard Cochran <richardcochran@...il.com>, andrew@...n.ch,
        davem@...emloft.net, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support
 [multicast/DSA issues]

On Tue, 28 Feb 2023 14:59:11 -0800
Jakub Kicinski <kuba@...nel.org> wrote:

> On Tue, 28 Feb 2023 22:40:05 +0000 Russell King (Oracle) wrote:
> > IMHO, it's better if the kernel automatically selects a sensible
> > default _and_ gives the user the ability to override it e.g. via
> > ethtool.  
> 
> Oh, I see, makes sense.

I suppose the idea of Russell to rate each PTP clocks may be the best one, as
all others solutions have drawbacks. Does using the PTP clock period value (in
picoseconds) is enough to decide which PTP is the best one? It is hardware
specific therefore it is legitimate to be set by the MAC and PHY drivers.

Regards,