netdev - Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6cfc194b-9d30-47d5-8ea9-fa5c13ad0e7c@app.fastmail.com>
Date:   Wed, 01 Mar 2023 09:01:27 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Larry Finger" <Larry.Finger@...inger.net>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Dominik Brodowski" <linux@...inikbrodowski.net>,
        linux-kernel@...r.kernel.org
Cc:     "Bjorn Helgaas" <bhelgaas@...gle.com>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        "Hartley Sweeten" <hsweeten@...ionengravers.com>,
        "Ian Abbott" <abbotti@....co.uk>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Kevin Cernekee" <cernekee@...il.com>,
        "Lukas Wunner" <lukas@...ner.de>,
        "Manuel Lauss" <manuel.lauss@...il.com>,
        "Oliver Hartkopp" <socketcan@...tkopp.net>,
        "Olof Johansson" <olof@...om.net>,
        "Robert Jarzmik" <robert.jarzmik@...e.fr>,
        "YOKOTA Hiroshi" <yokota@...lab.is.tsukuba.ac.jp>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-can@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-wireless@...r.kernel.org, Netdev <netdev@...r.kernel.org>
Subject: Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus

On Wed, Mar 1, 2023, at 02:13, Larry Finger wrote:
> On 2/28/23 02:37, Arnd Bergmann wrote:
>> My intention was to keep Cardbus support working with old defconfig files,
>> and I've not moved CONFIG_CARDBUS into a separate submenu between
>> CONFIG_PCI_HOTPLUG and CONFIG_PCI_CONTROLLER but left the driver in
>> drivers/pci/hotplug. I think that's the best compromise here, but maybe
>> the PCI maintainers have a better idea.
>
> I did a bit more investigation. My original .config had CONFIG_PCI_HOTPLUG not 
> defined, but did have CONFIG_CARDBUS and the various yenta modules turned on. 
> With your changes, the CONFIG_PCI_HOTPLUG overrode CARDBUS.
>
> I thought mine was a corner case, but now I am not sure. As stated above, the 
> Debian 12 factory configuration for ppc32 does not turn on PCI hotplug, but the 
> x86_64 configuration for openSUSE Tumbleweed does. The x86_64 configuration in 
> Fedora 37 does not contain CONFIG_PCI_HOTPLUG, but does have CARDBUS set.
>
> It seems that several distros may get the wrong result with this change,

As far as I can tell, this should work with the changes I described
above, since CONFIG_CARDBUS no longer depends on CONFIG_PCI_HOTPLUG.
I now uploaded the changed version to

https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=pccard-rework-2

    Arnd