netdev - Re: [PATCH net] net: tls: avoid hanging tasks on the tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKh_gZFgSBnF=TCBCspS-2EUWDT6vvXjsUvgM-rcQBqSw@mail.gmail.com>
Date:   Wed, 1 Mar 2023 10:13:50 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com,
        syzbot+9c0268252b8ef967c62e@...kaller.appspotmail.com,
        stable@...r.kernel.org, borisp@...dia.com,
        john.fastabend@...il.com, simon.horman@...ronome.com
Subject: Re: [PATCH net] net: tls: avoid hanging tasks on the tx_lock

On Wed, Mar 1, 2023 at 1:29 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> syzbot sent a hung task report and Eric explains that adversarial
> receiver may keep RWIN at 0 for a long time, so we are not guaranteed
> to make forward progress. Thread which took tx_lock and went to sleep
> may not release tx_lock for hours. Use interruptible sleep where
> possible and reschedule the work if it can't take the lock.
>
> Testing: existing selftest passes
>
> Reported-by: syzbot+9c0268252b8ef967c62e@...kaller.appspotmail.com
> Fixes: 79ffe6087e91 ("net/tls: add a TX lock")
> Link: https://lore.kernel.org/all/000000000000e412e905f5b46201@google.com/
> Cc: stable@...r.kernel.org # wait 4 weeks
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: borisp@...dia.com
> CC: john.fastabend@...il.com
> CC: simon.horman@...ronome.com
>

This seems sane to me, thanks.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>