netdev - Re: [PATCH iproute2] u32: fix TC_U32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM0EoMmNUB0jD1LqrAqX90jC+U03RtUCUb9GHxrNWNGweQCgYA@mail.gmail.com>
Date:   Wed, 1 Mar 2023 06:55:21 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2] u32: fix TC_U32_TERMINAL printing

On Tue, Feb 28, 2023 at 10:10 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> On Tue, Feb 28, 2023 at 05:55:30AM -0500, Jamal Hadi Salim wrote:
> > Hangbin,
> > Can you please run tdc tests on all tc (both for iproute2 and kernel)
> > changes you make and preferably show them in the commit log? If you
> > introduce something new then add a new tdc test case to cover it.
>
> OK, the patch fixed an issue I found when run tdc u32 test.
>
> 1..11
> not ok 1 afa9 - Add u32 with source match
>         Could not match regex pattern. Verify command output:
> filter protocol ip pref 1 u32 chain 0
> filter protocol ip pref 1 u32 chain 0 fh 800: ht divisor 1
> filter protocol ip pref 1 u32 chain 0 fh 800::800 order 2048 key ht 800 bkt 0 *flowid 1:1 not_in_hw
>   match 7f000001/ffffffff at 12
>         action order 1: gact action pass
>          random type none pass val 0
>          index 1 ref 1 bind 1
>
> After the fix, the u32.json test passed
>
> All test results:
>
> 1..11
> ok 1 afa9 - Add u32 with source match
> ok 2 6aa7 - Add/Replace u32 with source match and invalid indev
> ok 3 bc4d - Replace valid u32 with source match and invalid indev
> ok 4 648b - Add u32 with custom hash table
> ok 5 6658 - Add/Replace u32 with custom hash table and invalid handle
> ok 6 9d0a - Replace valid u32 with custom hash table and invalid handle
> ok 7 1644 - Add u32 filter that links to a custom hash table
> ok 8 74c2 - Add/Replace u32 filter with invalid hash table id
> ok 9 1fe6 - Replace valid u32 filter with invalid hash table id
> ok 10 0692 - Test u32 sample option, divisor 256
> ok 11 2478 - Test u32 sample option, divisor 16
>
>
> When I post the patch, I though this issue is a clear logic one, so I didn't
>  paste the test result.
>

I think we should make it a rule to run tdc going forward. Your last
submission's issue that Pedro fixed would have been trivially found
with tdc. My suggestion is to repost the patch including the tdc test
in the commit message.

cheers,
jamal

> Thanks
> Hangbin