[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230301150747.GB4691@breakpoint.cc>
Date: Wed, 1 Mar 2023 16:07:47 +0100
From: Florian Westphal <fw@...len.de>
To: Madhu Koriginja <madhu.koriginja@....com>
Cc: gerrit@....abdn.ac.uk, davem@...emloft.net, kuznet@....inr.ac.ru,
yoshfuji@...ux-ipv6.org, edumazet@...gle.com, dccp@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
vani.namala@....com
Subject: Re: [PATCH] [NETFILTER]: Keep conntrack reference until IPsecv6
policy checks are done
Madhu Koriginja <madhu.koriginja@....com> wrote:
> Keep the conntrack reference until policy checks have been performed for
> IPsec V6 NAT support. The reference needs to be dropped before a packet is
> queued to avoid having the conntrack module unloadable.
In the old days there was no ipv6 nat so its not surpising
that ipv6 discards the conntrack entry earlier than ipv4.
> - if (!(ipprot->flags & INET6_PROTO_NOPOLICY) &&
> - !xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb))
> - goto discard;
> +
> + if (!ipprot->flags & INET6_PROTO_NOPOLICY) {
This looks wrong, why did you drop the () ?
if (!(ipprot->flags & INET6_PROTO_NOPOLICY)) { ...
rest LGTM.
Powered by blists - more mailing lists