netdev - Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support [multicast/DSA issues]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230302092320.6ee8eb6d@kernel.org>
Date:   Thu, 2 Mar 2023 09:23:20 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Köry Maincent <kory.maincent@...tlin.com>
Cc:     "Russell King (Oracle)" <linux@...linux.org.uk>,
        Richard Cochran <richardcochran@...il.com>, andrew@...n.ch,
        davem@...emloft.net, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support
 [multicast/DSA issues]

On Thu, 2 Mar 2023 18:06:16 +0100 Köry Maincent wrote:
> I have measured it with the Marvell PHY and MACB MAC but it is the contrary on
> my side:
> https://lkml.kernel.org/netdev/20230302113752.057a3213@kmaincent-XPS-13-7390/
> Also PHY default seems more logical as it is nearer to the physical link, but
> still I am interesting by the answer as I am not a PTP expert. Is really PTP
> MAC often more precise than PTP PHY?

Do you happen to have a datasheet for MACB? The time stamping
capability is suspiciously saved in a variable called hw_dma_cap
which may indicate it's a DMA time stamp not a true PTP stamp.

Quite a few NICs/MACs support DMA time stamps because it's far 
easier to take the stamp where the descriptor writing logic is
(DMA block) than take it at the end of the MAC and haul it all 
the way thru the pipeline back to the DMA block.