Message-ID: <PSAPR03MB5653D7BAA0E5DDB2D03B341BF7B39@PSAPR03MB5653.apcprd03.prod.outlook.com>
Date:   Fri, 3 Mar 2023 08:59:38 +0000
From:   Haozhe Chang (常浩哲) 
        <Haozhe.Chang@...iatek.com>
To:     Loic Poulain <loic.poulain@...aro.org>
CC:     "stephan@...hold.net" <stephan@...hold.net>,
        "oneukum@...e.com" <oneukum@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
        "linuxwwan@...el.com" <linuxwwan@...el.com>,
        "m.chetan.kumar@...el.com" <m.chetan.kumar@...el.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Hua Yang (杨华) <Hua.Yang@...iatek.com>,
        "chiranjeevi.rapolu@...ux.intel.com" 
        <chiranjeevi.rapolu@...ux.intel.com>,
        Haijun Liu (刘海军) 
        <haijun.liu@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Xiayu Zhang (张夏宇) 
        <Xiayu.Zhang@...iatek.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "chandrashekar.devegowda@...el.com" 
        <chandrashekar.devegowda@...el.com>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "shangxiaojing@...wei.com" <shangxiaojing@...wei.com>,
        Lambert Wang (王伟) 
        <Lambert.Wang@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "ricardo.martinez@...ux.intel.com" <ricardo.martinez@...ux.intel.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: 回复: [PATCH v5] wwan: core: Support slicing in port TX flow of WWAN subsystem

Dear Loic

I'm sorry to bother you, but I want to know whether my patch is accepted by the community.
Because it seems to be a merge window, but the patch state still is "Not Applicable". Could you 
give me some suggestions about this patch state?

BR
Haozhe

-----邮件原件-----
发件人: Loic Poulain <loic.poulain@...aro.org> 
发送时间: 2022年12月14日 17:11
收件人: Haozhe Chang (常浩哲) <Haozhe.Chang@...iatek.com>
抄送: stephan@...hold.net; oneukum@...e.com; linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org; linux-remoteproc@...r.kernel.org; linuxwwan@...el.com; m.chetan.kumar@...el.com; linux-mediatek@...ts.infradead.org; Hua Yang (杨华) <Hua.Yang@...iatek.com>; chiranjeevi.rapolu@...ux.intel.com; Haijun Liu (刘海军) <haijun.liu@...iatek.com>; linux-arm-kernel@...ts.infradead.org; ryazanov.s.a@...il.com; kuba@...nel.org; Xiayu Zhang (张夏宇) <Xiayu.Zhang@...iatek.com>; pabeni@...hat.com; edumazet@...gle.com; chandrashekar.devegowda@...el.com; johannes@...solutions.net; gregkh@...uxfoundation.org; shangxiaojing@...wei.com; Lambert Wang (王伟) <Lambert.Wang@...iatek.com>; matthias.bgg@...il.com; davem@...emloft.net; ricardo.martinez@...ux.intel.com; netdev@...r.kernel.org
主题: Re: [PATCH v5] wwan: core: Support slicing in port TX flow of WWAN subsystem

> On Thu, 2022-12-01 at 10:56 +0100, Loic Poulain wrote:
> > On Thu, 24 Nov 2022 at 08:47, <haozhe.chang@...iatek.com> wrote:
> > >
> > > From: haozhe chang <haozhe.chang@...iatek.com>
> > >
> > > wwan_port_fops_write inputs the SKB parameter to the TX callback 
> > > of the WWAN device driver. However, the WWAN device (e.g., t7xx) 
> > > may have an MTU less than the size of SKB, causing the TX buffer 
> > > to be sliced and copied once more in the WWAN device driver.
> > >
> > > This patch implements the slicing in the WWAN subsystem and gives 
> > > the WWAN devices driver the option to slice(by frag_len) or not. 
> > > By doing so, the additional memory copy is reduced.
> > >
> > > Meanwhile, this patch gives WWAN devices driver the option to 
> > > reserve headroom in fragments for the device-specific metadata.
> > >
> > > Signed-off-by: haozhe chang <haozhe.chang@...iatek.com>
> >
> > Reviewed-by: Loic Poulain <loic.poulain@...aro.org>
>
> I have submitted patch V6 to add a reviewer, do you have any other 
> suggestions about the patch?

You normally don't need to resubmit a version just for adding review tags, as it is well tracked. You can see status of netdev changes from
patchwork:
https://urldefense.com/v3/__https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=207580&state=*&q=&archive=both&delegate=__;Kg!!CTRNKA9wMg0ARbw!jXuZ2mOXJnaIzFA696nBp09HXGpJBmuH1VVD_RRUAITEOXm--zUP8GDdAm0wa70-IbxCBmbRhYR9SaLn8Muf2bG1E68$  

Regarding this change you should however resubmit for the net-next tree with appropriate subject since it is not a bug fix:
https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html?highlight=netdev*how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in__;Iw!!CTRNKA9wMg0ARbw!jXuZ2mOXJnaIzFA696nBp09HXGpJBmuH1VVD_RRUAITEOXm--zUP8GDdAm0wa70-IbxCBmbRhYR9SaLn8Mufd3UkIVI$  

Then it should be picked by netdev maintainer(s). But note that we're currently in the Linux 6.2 merge window, so merging for net-next can be delayed until the mainline merge window is closed (and net-next
open):
https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html?highlight=netdev*how-often-do-changes-from-these-trees-make-it-to-the-mainline-linus-tree__;Iw!!CTRNKA9wMg0ARbw!jXuZ2mOXJnaIzFA696nBp09HXGpJBmuH1VVD_RRUAITEOXm--zUP8GDdAm0wa70-IbxCBmbRhYR9SaLn8MufBL1Lhxg$  

Regards,
Loic

Powered by blists - more mailing lists