netdev - RE: [Qestion] abort backport commit ("net/ulp: prevent ULP without clone op from entering the LISTEN status") in stable-4.19.x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55378c79847a4fe092cc924e4df24f4d@huawei.com>
Date:   Sat, 4 Mar 2023 02:45:44 +0000
From:   "liujian (CE)" <liujian56@...wei.com>
To:     "Iwashima, Kuniyuki" <kuniyu@...zon.co.jp>
CC:     Paolo Abeni <pabeni@...hat.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: RE: [Qestion] abort backport commit ("net/ulp: prevent ULP without
 clone op from entering the LISTEN status") in stable-4.19.x



> -----Original Message-----
> From: Iwashima, Kuniyuki [mailto:kuniyu@...zon.co.jp]
> Sent: Saturday, March 4, 2023 9:13 AM
> To: liujian (CE) <liujian56@...wei.com>
> Cc: Paolo Abeni <pabeni@...hat.com>; Greg KH
> <gregkh@...uxfoundation.org>; stable@...r.kernel.org; Network
> Development <netdev@...r.kernel.org>; Iwashima, Kuniyuki
> <kuniyu@...zon.co.jp>; Jakub Kicinski <kuba@...nel.org>
> Subject: Re: [Qestion] abort backport commit ("net/ulp: prevent ULP without
> clone op from entering the LISTEN status") in stable-4.19.x
> 
> From: Jakub Kicinski <kuba@...nel.org>
> Date: Fri, 3 Mar 2023 17:06:08 -0800
> > On Fri, 3 Mar 2023 10:52:15 +0000 liujian (CE) wrote:
> > > When I was working on CVE-2023-0461, I found the below backport
> commit in stable-4.19.x maybe something wrong?
> > >
> > > 755193f2523c ("net/ulp: prevent ULP without clone op from entering
> > > the LISTEN status")
> > >
> > > 1.  err = -EADDRINUSE in inet_csk_listen_start() was removed. But it
> > >     is the error code when get_port() fails.
> >
> > I think you're right, we should add setting the err back.
> 
> Yes, the same issue happened on 5.15.88, but I forgot to check other stable
> branches.
> I'll check them and post fixes later.
> https://lore.kernel.org/stable/20230220133555.140865685@linuxfoundation.
> org/
> 
Thanks Iwashima.
> 
> >
> > >  2. The change in __tcp_set_ulp() should not be discarded?
> >
> > That part should be fine, all ULPs in 4.19 (i.e. TLS) should fail the
> > ->init() call if sk_state != ESTABLISHED.
Got it. Thanks Jakub.