netdev - Re: [PATCH v3] netdevice: use ifmap instead of plain fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CQXUM7MRJU3X.321CXIWRLP8ZL@vincent-arch>
Date:   Sat, 04 Mar 2023 20:33:38 +0100
From:   "Vincenzo Palazzo" <vincenzopalazzodev@...il.com>
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <intel-wired-lan@...ts.osuosl.org>, <jesse.brandeburg@...el.com>,
        <khc@...waw.pl>, "kernel test robot" <lkp@...el.com>
Subject: Re: [PATCH v3] netdevice: use ifmap instead of plain fields

On Sat Mar 4, 2023 at 8:06 PM CET, Jakub Kicinski wrote:
> On Sat,  4 Mar 2023 12:56:26 +0100 Vincenzo Palazzo wrote:
> > clean the code by using the ifmap instead of plain fields,
> > and avoid code duplication.
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202303041847.nRrrz1v9-lkp@intel.com/
> > Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@...il.com>
>
> Please don't, as already explained it's not worth the code churn.

Ah! ok I got it, yes maybe this should be an RFC, I thought also that
this change will impact in so many things!

Ok, so I will remove just the FIXME that at this point is not 
useful anymore.

Cheers!

Vincent.