netdev - Re: [PATCH v1] netdevice: clean old FIXME that it is not worthed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230304121732.3d102b7e@hermes.local>
Date:   Sat, 4 Mar 2023 12:17:32 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vincenzo Palazzo <vincenzopalazzodev@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v1] netdevice: clean old FIXME that it is not worthed

On Sat,  4 Mar 2023 20:44:33 +0100
Vincenzo Palazzo <vincenzopalazzodev@...il.com> wrote:

> Alternative patch that removes an old FIXME because it currently
> the change is worthed as some comments in the patch point out
> (https://lore.kernel.org/all/20230304080650.74e8d396@hermes.local/#t)
> 
> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@...il.com>
> ---
>  include/linux/netdevice.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 6a14b7b11766..82af7eb62075 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2033,7 +2033,6 @@ struct net_device {
>  	struct dev_ifalias	__rcu *ifalias;
>  	/*
>  	 *	I/O specific fields
> -	 *	FIXME: Merge these and struct ifmap into one
>  	 */
>  	unsigned long		mem_end;
>  	unsigned long		mem_start;

These fields actually are only used by old hardware devices that
pre-date buses with auto discovery. I.e ISA bus not PCI.

Since ISA bus support is gone, either these devices should have
been removed as well or they really aren't using those fields..

If someone wanted to clean this stuff out, start by seeing
if any of those devices still live. For example, the E1000e has
a couple of variants and dropping support for the non-PCI variant
would be ok.

All of arcnet could/should go away? Maybe move to staging?

The wan devices might also have been ISA only devices that are now
unusable.