netdev - Re: [PATCH v8 1/5] mac80211_hwsim: add PMSR capability support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <addaa95e4c2e840ac041efcedc99a235af90c6c1.camel@sipsolutions.net>
Date:   Mon, 06 Mar 2023 17:58:37 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Simon Horman <simon.horman@...igine.com>,
        Jaewan Kim <jaewan@...gle.com>
Cc:     gregkh@...uxfoundation.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, kernel-team@...roid.com, adelva@...gle.com
Subject: Re: [PATCH v8 1/5] mac80211_hwsim: add PMSR capability support

> 
> > @@ -3186,6 +3218,7 @@ struct hwsim_new_radio_params {
> >  	u32 *ciphers;
> >  	u8 n_ciphers;
> >  	bool mlo;
> > +	const struct cfg80211_pmsr_capabilities *pmsr_capa;
> 
> nit: not related to this patch,
>      but there are lots of holes in hwsim_new_radio_params.
>      And, I think that all fields, other than the new pmsr_capa field,
>      could fit into one cacheline on x86_64.
> 
>      I'm unsure if it is worth cleaning up or not.
> 

Probably not. It's just a temporary thing there, I don't think we even
have it for longer than temporarily on the stack.

johannes