netdev - Re: [PATCH V5 01/15] spi: Replace all spi->chip_select and spi->cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Mar 2023 17:32:49 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>
Cc:     miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        jic23@...nel.org, tudor.ambarus@...rochip.com, pratyush@...nel.org,
        Sanju.Mehta@....com, chin-ting_kuo@...eedtech.com, clg@...d.org,
        kdasu.kdev@...il.com, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, eajames@...ux.ibm.com, olteanv@...il.com,
        han.xu@....com, john.garry@...wei.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, narmstrong@...libre.com,
        khilman@...libre.com, matthias.bgg@...il.com, haibo.chen@....com,
        linus.walleij@...aro.org, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        agross@...nel.org, bjorn.andersson@...aro.org, heiko@...ech.de,
        krzysztof.kozlowski@...aro.org, andi@...zian.org,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
        wens@...e.org, jernej.skrabec@...il.com, samuel@...lland.org,
        masahisa.kojima@...aro.org, jaswinder.singh@...aro.org,
        rostedt@...dmis.org, mingo@...hat.com, l.stelmach@...sung.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, alex.aring@...il.com, stefan@...enfreihafen.org,
        kvalo@...nel.org, james.schulman@...rus.com,
        david.rhodes@...rus.com, tanureal@...nsource.cirrus.com,
        rf@...nsource.cirrus.com, perex@...ex.cz, tiwai@...e.com,
        npiggin@...il.com, christophe.leroy@...roup.eu, mpe@...erman.id.au,
        oss@...error.net, windhl@....com, yangyingliang@...wei.com,
        william.zhang@...adcom.com, kursad.oney@...adcom.com,
        jonas.gorski@...il.com, anand.gore@...adcom.com, rafal@...ecki.pl,
        git@....com, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, joel@....id.au, andrew@...id.au,
        radu_nicolae.pirea@....ro, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        bcm-kernel-feedback-list@...adcom.com, fancer.lancer@...il.com,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
        avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
        venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
        yogeshgaur.83@...il.com, konrad.dybcio@...ainline.org,
        alim.akhtar@...sung.com, ldewangan@...dia.com,
        thierry.reding@...il.com, jonathanh@...dia.com,
        michal.simek@....com, linux-aspeed@...ts.ozlabs.org,
        openbmc@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
        netdev@...r.kernel.org, linux-wpan@...r.kernel.org,
        libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-mtd@...ts.infradead.org, lars@...afoo.de,
        Michael.Hennerich@...log.com, linux-iio@...r.kernel.org,
        michael@...le.cc, palmer@...belt.com,
        linux-riscv@...ts.infradead.org, alsa-devel@...a-project.org,
        patches@...nsource.cirrus.com, linuxppc-dev@...ts.ozlabs.org,
        amitrkcian2002@...il.com, Dhruva Gole <d-gole@...com>,
        Patrice Chotard <patrice.chotard@...s.st.com>
Subject: Re: [PATCH V5 01/15] spi: Replace all spi->chip_select and
 spi->cs_gpiod references with function call

On Mon, Mar 06, 2023 at 10:50:55PM +0530, Amit Kumar Mahapatra wrote:
> Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod
> members of struct spi_device to be an array. But changing the type of these
> members to array would break the spi driver functionality. To make the
> transition smoother introduced four new APIs to get/set the
> spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and
> spi->cs_gpiod references with get or set API calls.
> While adding multi-cs support in further patches the chip_select & cs_gpiod
> members of the spi_device structure would be converted to arrays & the
> "idx" parameter of the APIs would be used as array index i.e.,
> spi->chip_select[idx] & spi->cs_gpiod[idx] respectively.

This doesn't apply against current code, there was a rework of the
mpc512x-psc driver.  Please check and resend.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)