netdev - Re: [PATCH v3] virtio-net: Fix probe of virtio-net on kvmtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Mar 2023 10:12:34 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Jason Wang <jasowang@...hat.com>, rbradford@...osinc.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] virtio-net: Fix probe of virtio-net on kvmtool

On Sun, 5 Mar 2023 04:53:58 -0500 Michael S. Tsirkin wrote:
> > > yes what we do work according to code.  So the documentation is wrong then?  
> > 
> > It's definitely incomplete but which part are you saying is wrong?  
> 
> So it says:
>   2. netdev->features set contains features which are currently enabled
>      for a device.
> 
> ok so far.
> But this part:
> 
>   This should be changed only by network core or in
>      error paths of ndo_set_features callback.
> 
> seems to say virtio should not touch netdev->features, no?

Oh, I see, yes. We should add a mention of ndo_fix_features there,
and perhaps "see Part II for more information"?.

The sentence reads like someone was trying to make sure drivers don't
silently change features without calling netdev_update_features().