netdev - Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Date:   Mon, 06 Mar 2023 09:16:54 +0100
From:   Robin van der Gracht <robin@...tonic.nl>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
        netdev@...r.kernel.org, linux-can@...r.kernel.org,
        linux-wireless@...r.kernel.org, linux-pm@...r.kernel.org,
        alsa-devel@...a-project.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

> From: Rob Herring <robh@...nel.org>
> Date: Tue, Feb 28, 2023 at 10:54 PM
> Subject: [PATCH] dt-bindings: Fix SPI and I2C bus node names in 
> examples
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> Cc: <devicetree@...r.kernel.org>, Miguel Ojeda <ojeda@...nel.org>,
> Benson Leung <bleung@...omium.org>, Guenter Roeck
> <groeck@...omium.org>, Stephen Boyd <sboyd@...nel.org>, Andrzej Hajda
> <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
> Robert Foss <rfoss@...nel.org>, Thierry Reding
> <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>, MyungJoo
> Ham <myungjoo.ham@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>,
> Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
> <brgl@...ev.pl>, Pavel Machek <pavel@....cz>, Lee Jones
> <lee@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, David S.
> Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
> Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
> Wolfgang Grandegger <wg@...ndegger.com>, Kalle Valo
> <kvalo@...nel.org>, Sebastian Reichel <sre@...nel.org>, Mark Brown
> <broonie@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
> <linux-clk@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
> <linux-gpio@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
> <linux-leds@...r.kernel.org>, <linux-media@...r.kernel.org>,
> <netdev@...r.kernel.org>, <linux-can@...r.kernel.org>,
> <linux-wireless@...r.kernel.org>, <linux-pm@...r.kernel.org>,
> <alsa-devel@...a-project.org>, <linux-usb@...r.kernel.org>
> 
> 
> SPI and I2C bus node names are expected to be "spi" or "i2c",
> respectively, with nothing else, a unit-address, or a '-N' index. A
> pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these
> cases. Mostly scripted with the following commands:
> 
> git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e
> 's/i2c[0-9] {/i2c {/'
> git grep -l '\sspi[0-9] {' Documentation/devicetree/ | xargs sed -i -e
> 's/spi[0-9] {/spi {/'
> 
> With this, a few errors in examples were exposed and fixed.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> Cc: Miguel Ojeda <ojeda@...nel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> Cc: Benson Leung <bleung@...omium.org>
> Cc: Guenter Roeck <groeck@...omium.org>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: Andrzej Hajda <andrzej.hajda@...el.com>
> Cc: Neil Armstrong <neil.armstrong@...aro.org>
> Cc: Robert Foss <rfoss@...nel.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Bartosz Golaszewski <brgl@...ev.pl>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Lee Jones <lee@...nel.org>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Wolfgang Grandegger <wg@...ndegger.com>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-clk@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-i2c@...r.kernel.org
> Cc: linux-leds@...r.kernel.org
> Cc: linux-media@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: linux-can@...r.kernel.org
> Cc: linux-wireless@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Cc: alsa-devel@...a-project.org
> Cc: linux-usb@...r.kernel.org
> ---
>  .../bindings/auxdisplay/holtek,ht16k33.yaml       |  2 +-

....

>  86 files changed, 110 insertions(+), 103 deletions(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> index fc4873deb76f..286e726cd052 100644
> --- a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> +++ b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> @@ -72,7 +72,7 @@ examples:
>      #include <dt-bindings/interrupt-controller/irq.h>
>      #include <dt-bindings/input/input.h>
>      #include <dt-bindings/leds/common.h>
> -    i2c1 {
> +    i2c {
>              #address-cells = <1>;
>              #size-cells = <0>;

Acked-by: Robin van der Gracht <robin@...tonic.nl>