netdev - Re: [PATCH net] net: tls: fix device-offloaded sendpage straddling records

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAWtE34EJw79Oqkx@mail.gmail.com>
Date:   Mon, 6 Mar 2023 11:07:20 +0200
From:   Maxim Mikityanskiy <maxtram95@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, Adrien Moulin <amoulin@...p.free.fr>,
        borisp@...dia.com, john.fastabend@...il.com, tariqt@...dia.com,
        maximmi@...dia.com
Subject: Re: [PATCH net] net: tls: fix device-offloaded sendpage straddling
 records

On Sat, Mar 04, 2023 at 11:26:10AM -0800, Jakub Kicinski wrote:
> Adrien reports that incorrect data is transmitted when a single
> page straddles multiple records. We would transmit the same
> data in all iterations of the loop.
> 
> Reported-by: Adrien Moulin <amoulin@...p.free.fr>
> Link: https://lore.kernel.org/all/61481278.42813558.1677845235112.JavaMail.zimbra@corp.free.fr
> Fixes: c1318b39c7d3 ("tls: Add opt-in zerocopy mode of sendfile()")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

Thanks for the fix, looks good to me.

Acked-by: Maxim Mikityanskiy <maxtram95@...il.com>

> Maxim, can I add a .mailmap entry for you? get_maintainers
> will complain if I don't CC your @nvidia address :(

Yes please, that would be great. You can also add maximmi@...lanox.com,
in case someone refers to some old commit.