netdev - Re: htb offload on vlan (mlx5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAWz+iSrxfLnXX+N@mail.gmail.com>
Date:   Mon, 6 Mar 2023 11:35:54 +0200
From:   Maxim Mikityanskiy <maxtram95@...il.com>
To:     Stanisław Czech <s.czech@...atel.com>
Cc:     netdev@...r.kernel.org, Gal Pressman <gal@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: htb offload on vlan (mlx5)

On Fri, Mar 03, 2023 at 07:04:43PM +0100, Stanisław Czech wrote:
> Hi,
> 
> I'm trying to use htb offload on vlan interface using  ConnectX-6 card
> (01:00.0 Ethernet controller: Mellanox Technologies MT28908 Family
> [ConnectX-6])
> but it seems there is no such a capability on the vlan interface?
> 
> On a physical interface:
> 
> ethtool -k eth0 | grep hw-tc-offload
> hw-tc-offload: on
> 
> On a vlan:
> 
> ethtool -k eth0.4 | grep hw-tc-offload
> hw-tc-offload: off [fixed]
> 
> so while there is no problem with:
> tc qdisc replace dev eth0 root handle 1:0 htb offload default 2
> 
> I can't do:
> tc qdisc replace dev eth0.4 root handle 1:0 htb offload default 2
> Error: hw-tc-offload ethtool feature flag must be on.

Hi Stanisław,

That's expected, vlan_features doesn't contain NETIF_F_HW_TC, and I
think that's the case for all drivers. Regarding HTB offload, I don't
think the current implementation in mlx5e can be easily modified to
support being attached to a VLAN only, because the current
implementation relies on objects created globally in the NIC.

CCed Nvidia folks in case they have more comments.

> 
> 
> modinfo mlx5_core
> filename: /lib/modules/6.2.1-1.el9.elrepo.x86_64/kernel/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko.xz
> license:        Dual BSD/GPL
> description:    Mellanox 5th generation network adapters (ConnectX series)
> core driver
> author:         Eli Cohen <eli@...lanox.com>
> srcversion:     59FA0D4A4E95B726AB8900D
> 
> Is there a different way to use htb offload on the vlan interface?
> 
> Greetings,
> *Stanisław Czech*
>