lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Mar 2023 14:15:48 +0200 From: Vladimir Oltean <olteanv@...il.com> To: Daniel Golle <daniel@...rotopia.org> Cc: netdev@...r.kernel.org, linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>, Heiner Kallweit <hkallweit1@...il.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Mark Lee <Mark-MC.Lee@...iatek.com>, John Crispin <john@...ozen.org>, Felix Fietkau <nbd@....name>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Matthias Brugger <matthias.bgg@...il.com>, DENG Qingfang <dqfext@...il.com>, Landen Chao <Landen.Chao@...iatek.com>, Sean Wang <sean.wang@...iatek.com>, Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <vladimir.oltean@....com>, Bjørn Mork <bjorn@...k.no>, arinc9.unal@...il.com, frank-w@...lic-files.de Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix RX data corruption issue On Sat, Mar 04, 2023 at 01:43:20PM +0000, Daniel Golle wrote: > Fix data corruption issue with SerDes connected PHYs operating at 1.25 > Gbps speed where we could previously observe about 30% packet loss while > the bad packet counter was increasing. > > As almost all boards with MediaTek MT7622 or MT7986 use either the MT7531 > switch IC operating at 3.125Gbps SerDes rate or single-port PHYs using > rate-adaptation to 2500Base-X mode, this issue only got exposed now when > we started trying to use SFP modules operating with 1.25 Gbps with the > BananaPi R3 board. > > The fix is to set bit 12 which disables the RX FIFO clear function when > setting up MAC MCR, MediaTek SDK did the same change stating: > "If without this patch, kernel might receive invalid packets that are > corrupted by GMAC."[1] > > [1]: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/d8a2975939a12686c4a95c40db21efdc3f821f63 > > Fixes: 42c03844e93d ("net-next: mediatek: add support for MediaTek MT7622 SoC") > Tested-by: Bjørn Mork <bjorn@...k.no> > Signed-off-by: Daniel Golle <daniel@...rotopia.org> > --- I don't see something particularly controversial with this change. Reviewed-by: Vladimir Oltean <olteanv@...il.com>
Powered by blists - more mailing lists