netdev - Re: [PATCH net-next] net: reclaim skb->scm_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bad4c222-de52-625e-e73d-5997a7553a57@kernel.dk>
Date:   Tue, 7 Mar 2023 08:24:59 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        Pavel Begunkov <asml.silence@...il.com>,
        Thadeu Lima de Souza Cascardo <cascardo@...onical.com>
Subject: Re: [PATCH net-next] net: reclaim skb->scm_io_uring bit

On 3/7/23 7:59 AM, Eric Dumazet wrote:
> Commit 0091bfc81741 ("io_uring/af_unix: defer registered
> files gc to io_uring release") added one bit to struct sk_buff.
> 
> This structure is critical for networking, and we try very hard
> to not add bloat on it, unless absolutely required.

Understandable.

> For instance, we can use a specific destructor as a wrapper
> around unix_destruct_scm(), to identify skbs that unix_gc()
> has to special case.

Looks fine to me:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe