[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZAdaO0w2u8AL27un@corigine.com>
Date: Tue, 7 Mar 2023 16:37:31 +0100
From: Simon Horman <simon.horman@...igine.com>
To: haozhe.chang@...iatek.com
Cc: M Chetan Kumar <m.chetan.kumar@...el.com>,
Intel Corporation <linuxwwan@...el.com>,
Loic Poulain <loic.poulain@...aro.org>,
Sergey Ryazanov <ryazanov.s.a@...il.com>,
Johannes Berg <johannes@...solutions.net>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Stephan Gerhold <stephan@...hold.net>,
Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>,
Liu Haijun <haijun.liu@...iatek.com>,
Ricardo Martinez <ricardo.martinez@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Oliver Neukum <oneukum@...e.com>,
Shang XiaoJing <shangxiaojing@...wei.com>,
"open list:INTEL WWAN IOSM DRIVER" <netdev@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
"open list:REMOTE PROCESSOR MESSAGING (RPMSG) WWAN CONTROL..."
<linux-remoteproc@...r.kernel.org>,
"open list:USB SUBSYSTEM" <linux-usb@...r.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>, lambert.wang@...iatek.com,
xiayu.zhang@...iatek.com, hua.yang@...iatek.com
Subject: Re: [PATCH RESEND net-next] wwan: core: Support slicing in port TX
flow of WWAN subsystem
On Tue, Mar 07, 2023 at 04:11:04PM +0800, haozhe.chang@...iatek.com wrote:
> From: haozhe chang <haozhe.chang@...iatek.com>
>
> wwan_port_fops_write inputs the SKB parameter to the TX callback of
> the WWAN device driver. However, the WWAN device (e.g., t7xx) may
> have an MTU less than the size of SKB, causing the TX buffer to be
> sliced and copied once more in the WWAN device driver.
>
> This patch implements the slicing in the WWAN subsystem and gives
> the WWAN devices driver the option to slice(by frag_len) or not. By
> doing so, the additional memory copy is reduced.
>
> Meanwhile, this patch gives WWAN devices driver the option to reserve
> headroom in fragments for the device-specific metadata.
>
> Signed-off-by: haozhe chang <haozhe.chang@...iatek.com>
> Reviewed-by: Loic Poulain <loic.poulain@...aro.org>
>
> ---
> Changes in v2
> -send fragments to device driver by skb frag_list.
>
> Changes in v3
> -move frag_len and headroom_len setting to wwan_create_port.
>
> Changes in v4
> -change unreadable parameters to macro definition.
>
> Changes in v5
> -optimize comments for WWAN_NO_HEADROOM, WWAN_NO_FRAGMENT.
>
> Changes in v6
> -add reviewer to patch commit.
Thanks for resending.
Perhaps I am missing something terribly obvious,
but this patch does not seem to apply against net-next (anymore?).
I think it would be best to rebase and post a v7.
Also, the version was missing from the patch subject (but present in v5).
Powered by blists - more mailing lists