[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZAdndDaDiuSy5Lwf@corigine.com>
Date: Tue, 7 Mar 2023 17:33:56 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, lars.povlsen@...rochip.com,
Steen.Hegelund@...rochip.com, UNGLinuxDriver@...rochip.com,
joe@...ches.com, error27@...il.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: microchip: sparx5: fix deletion of existing
DSCP mappings
On Tue, Mar 07, 2023 at 12:21:03PM +0100, Daniel Machon wrote:
> Fix deletion of existing DSCP mappings in the APP table.
>
> Adding and deleting DSCP entries are replicated per-port, since the
> mapping table is global for all ports in the chip. Whenever a mapping
> for a DSCP value already exists, the old mapping is deleted first.
> However, it is only deleted for the specified port. Fix this by calling
> sparx5_dcb_ieee_delapp() instead of dcb_ieee_delapp() as it ought to be.
>
> Reproduce:
>
> // Map and remap DSCP value 63
> $ dcb app add dev eth0 dscp-prio 63:1
> $ dcb app add dev eth0 dscp-prio 63:2
>
> $ dcb app show dev eth0 dscp-prio
> dscp-prio 63:2
>
> $ dcb app show dev eth1 dscp-prio
> dscp-prio 63:1 63:2 <-- 63:1 should not be there
>
> Fixes: 8dcf69a64118 ("net: microchip: sparx5: add support for offloading dscp table")
> Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>
Reviewed-by: Simon Horman <simon.horman@...igine.com>
Powered by blists - more mailing lists