[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <583cc2c7-7883-57fe-6b48-25e5e43c3ec0@blackwall.org>
Date: Tue, 7 Mar 2023 11:20:03 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Xin Long <lucien.xin@...il.com>, netfilter-devel@...r.kernel.org,
network dev <netdev@...r.kernel.org>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
Florian Westphal <fw@...len.de>, davem@...emloft.net,
kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Roopa Prabhu <roopa@...dia.com>,
Pravin B Shelar <pshelar@....org>,
Aaron Conole <aconole@...hat.com>
Subject: Re: [PATCH nf-next 2/6] netfilter: bridge: check len before accessing
more nh data
On 04/03/2023 02:12, Xin Long wrote:
> In the while loop of br_nf_check_hbh_len(), similar to ip6_parse_tlv(),
> before accessing 'nh[off + 1]', it should add a check 'len < 2'; and
> before parsing IPV6_TLV_JUMBO, it should add a check 'optlen > len',
> in case of overflows.
>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
> net/bridge/br_netfilter_ipv6.c | 47 ++++++++++++++++------------------
> 1 file changed, 22 insertions(+), 25 deletions(-)
Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>
Powered by blists - more mailing lists