netdev - Re: linux-next: Signed-off-by missing for commit in the net tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230307115252.2b23c4f5@oak.ozlabs.ibm.com>
Date:   Tue, 7 Mar 2023 11:52:52 +1100
From:   Stephen Rothwell <sfr@...hwell.id.au>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the net tree

Hi Heiner,

On Mon, 6 Mar 2023 23:16:09 +0100 Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> On 06.03.2023 22:37, Stephen Rothwell wrote:
> > 
> > Commit
> > 
> >   58aac3a2ef41 ("net: phy: smsc: fix link up detection in forced irq mode")
> > 
> > is missing a Signed-off-by from its committer.
> 
> Seems to be ok, false positive?
> 
> net: phy: smsc: fix link up detection in forced irq mode
> Currently link up can't be detected in forced mode if polling
> isn't used. Only link up interrupt source we have is aneg
> complete which isn't applicable in forced mode. Therefore we
> have to use energy-on as link up indicator.
> 
> Fixes: 7365494550f6 ("net: phy: smsc: skip ENERGYON interrupt if disabled")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>

It was committed by Jakub Kicinski <kuba@...nel.org>

$ git show --pretty=raw 58aac3a2ef41
commit 58aac3a2ef414fea6d7fdf823ea177744a087d13
tree 26bf9b3b866bd43baa1b8055d42536ac7ce3b3cf
parent 89b59a84cb166f1ab5b6de9830e61324937c661e
author Heiner Kallweit <hkallweit1@...il.com> 1677927164 +0100
committer Jakub Kicinski <kuba@...nel.org> 1678137790 -0800

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped